Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ILL requests appear in the patron account even if they are closed or refused #2076

Closed
pronguen opened this issue Jun 24, 2021 · 0 comments · Fixed by rero/rero-ils-ui#650
Closed

ILL requests appear in the patron account even if they are closed or refused #2076

pronguen opened this issue Jun 24, 2021 · 0 comments · Fixed by rero/rero-ils-ui#650
Assignees
@zannkukai
Labels
enhancement Improvement of an existing feature f: circulation Concerns the circulation interface or backend p-Medium Medium priority (to be solved within 1-2 years)

Comments

@pronguen
Copy link
Contributor

pronguen commented Jun 24, 2021 •
edited
Loading

How it works

An interlibrary loan request appear in the patron account even if they are closed or refused. Two status are displayed:

image

Improvement suggestion

ILL request appear in the patron account (public + professional interface), if:

  • status is not "denied" or "closed"
  • loan_status is not "ITEM_RETURNED"

Only the loan_status is shown in the account.
@pronguen pronguen added enhancement Improvement of an existing feature triage p-Medium Medium priority (to be solved within 1-2 years) f: circulation Concerns the circulation interface or backend and removed triage labels Jun 24, 2021
@zannkukai zannkukai self-assigned this Jun 25, 2021
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jun 25, 2021
@zannkukai
ILL requests: fix public view
b9bbf9c 
Closes rero/rero-ils#2076.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Jun 25, 2021
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jun 25, 2021
@zannkukai
ILL requests: fix public view
b40dad5 
Closes rero/rero-ils#2076.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jun 28, 2021
@zannkukai
ILL requests: fix public view
74430a3 
Closes rero/rero-ils#2076.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jun 28, 2021
@zannkukai
ILL requests: fix public view
62fefe0 
Closes rero/rero-ils#2076.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to rero/rero-ils-ui that referenced this issue Jun 28, 2021
@zannkukai
ILL requests: fix public view
def4b95 
Closes rero/rero-ils#2076.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
enhancement Improvement of an existing feature f: circulation Concerns the circulation interface or backend p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ILL requests: fix public view zannkukai/rero-ils-ui
2 participants
@pronguen @zannkukai