Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item are displayed on the fly on document detailed view #2134

Closed
pronguen opened this issue Jul 8, 2021 · 0 comments · Fixed by rero/rero-ils-ui#671
Closed

Item are displayed on the fly on document detailed view #2134

pronguen opened this issue Jul 8, 2021 · 0 comments · Fixed by rero/rero-ils-ui#671
Assignees
@zannkukai
Labels
enhancement Improvement of an existing feature f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years) performance UX User experience, ergonomy

Comments

@pronguen
Copy link
Contributor

pronguen commented Jul 8, 2021

How it works

Currently, items are loaded at the same time that the document detailed view and all holdings:

  • only the 4 first holdings are displayed in the public interface
  • only the 5 first holdings are displayed in the professional interface

When clicking on "Show more", 4 or 5 more holdings are displayed, which is not user-friendly.

The same happens with the items: the 5 first are displayed and ones needs to click on "Show more".

Improvement suggestion

  • When loading a document detailed view (public + pro interface), only the holdings are loaded, not the items.
  • At least 10 holdings are loaded, more if performance permits it. This must be the same number in public and pro interface.
  • When opening / un-collapsing / extending a holdings, the items are loaded 10 by 10.
@pronguen pronguen added enhancement Improvement of an existing feature f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface performance p-Medium Medium priority (to be solved within 1-2 years) UX User experience, ergonomy labels Jul 8, 2021
@pronguen pronguen mentioned this issue Jul 8, 2021
Closed
@zannkukai zannkukai self-assigned this Jul 12, 2021
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jul 13, 2021
@zannkukai
document: upgrade holdings/items display
5b6b638 
* Loads/displays more holding by default (10). Collapse holdings panels if
  there are more than 1 holdings to display.
* Loads/displays more items by default (10).
* Fixes linting of `public-search` project.
* Harmonizes public/professional document view.
* Closes rero/rero-ils#2134.
* Closes rero/rero-ils#2133.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Jul 13, 2021
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jul 20, 2021
@zannkukai
documents: optimize holdings/items display
8c532e0 
* Loads/displays more holding by default (10). Collapse holdings panels if
  there are more than 1 holdings to display.
* Loads/displays more items by default (10).
* Fixes linting of `public-search` project.
* Harmonizes public/professional document view.
* Closes rero/rero-ils#2134.
* Closes rero/rero-ils#2133.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jul 20, 2021
@zannkukai
documents: optimize holdings/items display
0beef38 
* Loads/displays more holding by default (10). Collapse holdings panels if
  there are more than 1 holdings to display.
* Loads/displays more items by default (10).
* Fixes linting of `public-search` project.
* Harmonizes public/professional document view.
* Closes rero/rero-ils#2134.
* Closes rero/rero-ils#2133.
* Closes rero/rero-ils#2172.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jul 20, 2021
@zannkukai
documents: optimize holdings/items display
bddc129 
* Loads/displays more holding by default (10). Collapse holdings panels if
  there are more than 1 holdings to display.
* Loads/displays more items by default (10).
* Fixes linting of `public-search` project.
* Harmonizes public/professional document view.
* Closes rero/rero-ils#2134.
* Closes rero/rero-ils#2133.
* Closes rero/rero-ils#2172.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
iGormilhit pushed a commit to rero/rero-ils-ui that referenced this issue Jul 20, 2021
@zannkukai
documents: optimize holdings/items display
bd6e0d6 
* Loads/displays more holding by default (10). Collapse holdings panels if
  there are more than 1 holdings to display.
* Loads/displays more items by default (10).
* Fixes linting of `public-search` project.
* Harmonizes public/professional document view.
* Closes rero/rero-ils#2134.
* Closes rero/rero-ils#2133.
* Closes rero/rero-ils#2172.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
enhancement Improvement of an existing feature f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years) performance UX User experience, ergonomy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

documents: optimize holdings/items display zannkukai/rero-ils-ui
2 participants
@pronguen @zannkukai