Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some e-mails / notifications for the patron sent to the library don't have the addressee block #2188

Closed
pronguen opened this issue Jul 19, 2021 · 2 comments · Fixed by #2221
Closed

Some e-mails / notifications for the patron sent to the library don't have the addressee block #2188

pronguen opened this issue Jul 19, 2021 · 2 comments · Fixed by #2221
Labels
f: notifications p-High High priority (to be solved in the 2-3 next months) production Issue specifically spotted on the production server
Milestone
v1.4.6

Comments

@pronguen
Copy link
Contributor

pronguen commented Jul 19, 2021 •
edited
Loading

Describe the bug

Some e-mails / notifications for the patron sent to the library don't have the addressee block (name, street, city of the patron). The library does not know for who the communication is meant.

To Reproduce

See example

  • take a patron X without e-mail
  • do a checkout for X
  • on the same item, create a request for another patron
  • the e-mail sent to the library does not contain the addressee X

Expected behavior

  • Change the fixture: make of Helder a patron without e-mail and with mail communication channel!
  • E-mails for patron that are sent to the library (because the patron's communication channel is mail or because the patron has no e-mail) always contain the addressee block.

This concerns the following notification types: due_soon, recall, reminder, availability

Context

  • server: bib.rero.ch
  • version: v1.4.3

Screenshots

This e-mail should contain the addressee block of patron.pid:54282*

De : noreply@rero.ch noreply@rero.ch
Envoyé : vendredi, 16 juillet 2021 15:07 À : Pret MVSION
Objet : Document non prolongeable

Chère lectrice, cher lecteur,

Le document que vous avez emprunté vient d'être réservé par une autre personne. D'ores et déjà nous vous signalons que nous ne pourrons pas le prolonger et vous demandons de bien vouloir le restituer au plus tard à la date d'échéance.
Titre : M, le bord de l'abîme : thriller / Bernard Minier Échéance : 11.08.2021 Note : Non prolongeable

Vous pouvez consulter votre compte à l'adresse : https://bib.rero.ch/vs/patrons/profile

Avec nos compliments

SION - Médiathèque Valais
Rue de Lausanne 45, CP 182, CH - 1950 Sion
@pronguen pronguen added f: notifications bug Breaks something but is not blocking p-High High priority (to be solved in the 2-3 next months) production Issue specifically spotted on the production server labels Jul 19, 2021
@iGormilhit iGormilhit added this to the v1.4.5 milestone Jul 20, 2021
@iGormilhit iGormilhit added correction and removed bug Breaks something but is not blocking labels Jul 20, 2021
@iGormilhit iGormilhit modified the milestones: v1.4.5, v1.4.6 Jul 21, 2021
jma added a commit to jma/rero-ils that referenced this issue Jul 21, 2021
@jma @Garfield-fr
notifications: fix patron address block missing
bb9e2fe 
* Adds a patron address block to a printing patron notification.
* Closes rero#2188.

Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@jma jma mentioned this issue Jul 21, 2021
Merged
7 tasks
@jma jma closed this as completed in #2221 Jul 21, 2021
jma added a commit that referenced this issue Jul 21, 2021
@jma @Garfield-fr
notifications: fix patron address block missing
4476ce4 
* Adds a patron address block to a printing patron notification.
* Closes #2188.

Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@pronguen
Copy link
Contributor Author

pronguen commented Aug 2, 2021

@jma I tested it on ils.test.rero.ch (v1.4.5) and this issue is not solved. Is it deployed?
Libraries still observed this problem on the production (1.4.5 or 1.4.6).

@pronguen pronguen reopened this Aug 2, 2021
@pronguen
Copy link
Contributor Author

pronguen commented Aug 5, 2021

I close it. My previous message was not correct.

@pronguen pronguen closed this as completed Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
f: notifications p-High High priority (to be solved in the 2-3 next months) production Issue specifically spotted on the production server
Projects
None yet
Milestone
v1.4.6
Development

Successfully merging a pull request may close this issue.

notifications: fix patron address block missing jma/rero-ils
2 participants
@iGormilhit @pronguen