Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Due date not computed correcty (also after renewal) #2198

Closed
pronguen opened this issue Jul 19, 2021 · 1 comment · Fixed by #2435
Closed

Due date not computed correcty (also after renewal) #2198

pronguen opened this issue Jul 19, 2021 · 1 comment · Fixed by #2435
Assignees
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend p-High High priority (to be solved in the 2-3 next months)
Milestone

Comments

@pronguen
Copy link
Contributor

pronguen commented Jul 19, 2021

Describe the bug

Case 1: Renewal date is sometime one day later than checkout date, and does not respect the open days of the library.

Case 2: The loan duration is not exactly the same than in the circulation policy (in general 1 or 2 days longer) and does not respect the library open days.

To Reproduce

Case 1

  1. Take a patron account
  2. Use two items with the same item type.
  3. Set the same loan and renewal duration (for inst. 28 days for both)
  4. Do a renewal on one item and a checkout on the other
  5. See the different due dates

Case 2

  1. Log in bib.rero.ch as a Valais professional
  2. Do a checkout for a standard patron with a standard item (should be a 28 days checkout)
    • use item barcode test_rero on patron.pid 223550
  3. See that the due date is not correct

Expected behavior

Due date respects the circulation policy settings and the library open days.

Context

@pronguen pronguen added f: circulation Concerns the circulation interface or backend triage bug Breaks something but is not blocking p-Medium Medium priority (to be solved within 1-2 years) and removed triage labels Jul 19, 2021
@pronguen pronguen added p-High High priority (to be solved in the 2-3 next months) and removed p-Medium Medium priority (to be solved within 1-2 years) labels Aug 23, 2021
@iGormilhit iGormilhit changed the title Renewal date is sometime one day more than checkout date Due date not computed correcty (also after renewal) Aug 30, 2021
@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Sep 8, 2021

I'm note sure if it is linked but on our instance (ver.1.4.9), we tested checking out an item with a circulation policy 'onsite' (0 days).
The item should be overdue the same day at night but on the user account the item is overdue the next day.
Note: the due date in the overdue notification is correct and it counts the fees correctly.
In the screenshot below, the due date should be the 6/09 PM but it says 7/09 on the user account.
image

image

@pronguen pronguen added this to the v1.6.0 milestone Sep 21, 2021
@zannkukai zannkukai self-assigned this Sep 28, 2021
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 4, 2021
* Closes rero#2198.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
iGormilhit pushed a commit that referenced this issue Oct 6, 2021
* Closes #2198.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants