Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlap of opening hours #222

Closed
pronguen opened this issue Mar 18, 2019 · 0 comments
Closed

Overlap of opening hours #222

pronguen opened this issue Mar 18, 2019 · 0 comments
Labels
effort: minor Solved quickly enhancement Improvement of an existing feature

Comments

@pronguen
Copy link
Contributor

When editing library opening hours, the system indicates a false overlap when the eary period is entered after the late period (ex: 14.00-16.00, 10.00-12.00).
It should accept the two periods and reorder them automatically.
@pronguen pronguen added bug effort: minor Solved quickly labels Mar 18, 2019
@pronguen pronguen added this to the JR-2019 milestone Mar 18, 2019
@iGormilhit iGormilhit added enhancement Improvement of an existing feature and removed bug labels Mar 25, 2019
@iGormilhit iGormilhit removed this from the JR-2019 milestone Mar 25, 2019
@iGormilhit iGormilhit added the UI label Mar 25, 2019
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 2, 2019
@Garfield-fr
library admin: improvement
f891c7d 
* NEW Reorder opening hours for 1 day if the second hour is less than the first hour
* BETTER Improvement of the overlap validator if the second hour is less than the first hour
* FIX Closes rero#222

Signed-off-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue Apr 2, 2019
Merged
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 3, 2019
@Garfield-fr
library admin: improvement
2cb321a 
* NEW Reorders opening hours for 1 day if the second hour is less than the first hour
* BETTER Improves the overlap validator if the second hour is less than the first hour
* FIX Closes rero#222

Signed-off-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 3, 2019
@Garfield-fr
library admin: improvement
82c5287 
* NEW Reorders opening hours for 1 day if the second hour is less than the first hour
* BETTER Improves the overlap validator if the second hour is less than the first hour
* FIX Closes rero#222

Signed-off-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 3, 2019
@Garfield-fr
library admin: improvement
5751a43 
* NEW Reorders opening hours for 1 day if the second hour is less than the first hour
* BETTER Improves the overlap validator if the second hour is less than the first hour
* FIX Closes rero#222

Signed-off-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 3, 2019
@Garfield-fr
library admin: improvement
c965321 
* NEW Reorders opening hours for 1 day if the second hour is less than the first hour
* BETTER Improves the overlap validator if the second hour is less than the first hour
* FIX Closes rero#222

Signed-off-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
jma pushed a commit that referenced this issue Apr 8, 2019
@Garfield-fr @jma
library admin: improvement
b4f4a64 
* NEW Reorders opening hours for 1 day if the second hour is less than the first hour
* BETTER Improves the overlap validator if the second hour is less than the first hour
* FIX Closes #222

Signed-off-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@jma jma closed this as completed in 4973a2e May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: minor Solved quickly enhancement Improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iGormilhit @pronguen