Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A template created from an existing record can't be used #2269

Closed
jma opened this issue Aug 4, 2021 · 1 comment · Fixed by #2270
Closed

A template created from an existing record can't be used #2269

jma opened this issue Aug 4, 2021 · 1 comment · Fixed by #2270
Assignees
Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor

Comments

@jma
Copy link
Contributor

jma commented Aug 4, 2021

Describe the bug

When a template is created from an existing record (from the record editor in update mode), it can't be used: it cause an error during the record submission.

To Reproduce

  1. Edit an existing record
  2. Save as template
  3. Create an new record from this template
  4. Submit the record: an error is given

Expected behavior

Context

  • server: bib.rero.ch
  • version: v1.4.6
  • sentry Event 926b1c0bae264efc9d0e687b604854e2

Screenshots

Additional context

Note: the problem is that the pid is not removed during the template creation. A mass correction should be done to fix the existing templates.

@jma jma added triage bug Breaks something but is not blocking labels Aug 4, 2021
@BadrAly BadrAly self-assigned this Aug 4, 2021
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Aug 4, 2021
* Closes rero#2269

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Aug 5, 2021
* Closes rero#2269

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly
Copy link

BadrAly commented Aug 5, 2021

5.8.2021: Removed the pid from the following templates in production:

# 133 documents Catalogue d'expo MAHB
# 138 holdings mensuel simple
# 152 items exmplr 1CD+1 livret
# 153 items exmplr 1CD+1 livret
# 186 documents PAJU
# 189 items Exemplaire s019
# 190 documents s019
# 227 items Mag. enfant avec CD
# 233 documents No comment 21.07.2021
# 247 documents Documentaire
# 251 documents s019 / 28.07.2021
# 273 items ARTO_exemplaire
# 274 documents Fonds PAM
# 275 items Fonds PAM_exemplaire
# 285 documents BVCF CD Chanson française (à contrôler)

BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Aug 5, 2021
* Closes rero#2269

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Aug 10, 2021
* Closes rero#2269

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Aug 10, 2021
* Closes rero#2269

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit that referenced this issue Aug 10, 2021
* Closes #2269

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@iGormilhit iGormilhit added f: editor Concerns editor based on JSON schema AND custom editor and removed triage labels Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants