Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check-out of an item "in transit" #230

Closed
pronguen opened this issue Mar 20, 2019 · 3 comments
Closed

Check-out of an item "in transit" #230

pronguen opened this issue Mar 20, 2019 · 3 comments
Assignees
Labels
enhancement Improvement of an existing feature f: circulation Concerns the circulation interface or backend

Comments

@pronguen
Copy link
Contributor

An item which is "in transit" cannot be checked out. This should be possible, if the item has no request, or if the request is for the user concerned by the check-out.

@pronguen pronguen added bug f: circulation Concerns the circulation interface or backend labels Mar 20, 2019
@BadrAly BadrAly added enhancement Improvement of an existing feature and removed bug labels Mar 20, 2019
@BadrAly
Copy link

BadrAly commented Apr 10, 2019

According to the state chart in-transit items needs the action receive first before the checkout action.

We can allow the execution of these two actions receive + checkout in one step ONLY if the librarian is logged on to the library = request.pickup_library.

Any ideas @iGormilhit and @pronguen ?

@pronguen
Copy link
Contributor Author

pronguen commented Apr 10, 2019

Two cases:

  1. The item has no request (it is in transit to owning library): in that case, it should be possible to check it out for any one, from any library.
  2. The item has a request (it is in transit to pickup library): in that case, is should be
    2.1 possible to check it out, if it is for the user holding a request on this item (first in the request list)
    2.2 impossible to check it out, if it is for another user (holding no request, or holding a request but not at first position in the request list)

Ideally, the state chart must allow a check-out, even if it not from the pick-up library, as soon as the above mentioned conditions are satisfied. There is no need (no use case) to verify the pick-up library.

@BadrAly
Copy link

BadrAly commented Apr 10, 2019

👍 OK to resume in state chart terminology:-

Case 1: checkout is possible if loan.status = ITEM_IN_TRANSIT_TO_HOUSE and item has no pending requests. The active loan will be marked as CANCELLED

Case 2.1: checkout is possible if loan.status = ITEM_IN_TRANSIT_FOR_PICKUP and loan.patron_id = checked-out patron

@BadrAly BadrAly self-assigned this Apr 11, 2019
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Apr 17, 2019
* NEW Allows checkout of in-transit items.
* FIX Fixes rero#230.

Signed-off-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue May 2, 2019
* NEW Allows checkout of in-transit items.
* FIX Fixes rero#230.

Signed-off-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue May 2, 2019
* NEW Allows checkout of in-transit items.
* FIX Fixes rero#230.

Signed-off-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue May 6, 2019
* FIX Fixes rero#230: allows checkout of in-transit items.

Signed-off-by: Aly Badr <aly.badr@rero.ch>
jma pushed a commit that referenced this issue May 6, 2019
* FIX Fixes #230: allows checkout of in-transit items.

Signed-off-by: Aly Badr <aly.badr@rero.ch>
@jma jma closed this as completed in 91a5f48 May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature f: circulation Concerns the circulation interface or backend
Projects
None yet
Development

No branches or pull requests

2 participants