Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document: the temporary location URL (route) is wrong #2337

Closed
ManaDeweerdt opened this issue Aug 26, 2021 · 1 comment · Fixed by rero/rero-ils-ui#710
Closed

Document: the temporary location URL (route) is wrong #2337

ManaDeweerdt opened this issue Aug 26, 2021 · 1 comment · Fixed by rero/rero-ils-ui#710
Assignees
@Garfield-fr
Labels
bug Breaks something but is not blocking f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v1.6.0

Comments

@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Aug 26, 2021 •
edited by iGormilhit
Loading

Describe the bug

In the public interface, the link of the collection is not working on the document detail view.

To Reproduce

  1. Find a collection. Click on the document url.
  2. Click on the temporary location field. Ex: https://ilsdev.test.rero.ch/highlands/documents/4/
  3. Right click on it. Ex: https://ilsdev.test.rero.ch/highlands/documents/4/highlands/collections/6
  4. See error (page not found)

Expected behavior

The link of the temporary location field should redirect to the collection page.
Context
@ManaDeweerdt ManaDeweerdt added f: public ui Public interface, as opposed to the professional interface triage bug Breaks something but is not blocking p-Medium Medium priority (to be solved within 1-2 years) labels Aug 26, 2021
@iGormilhit iGormilhit removed the triage label Aug 30, 2021
@iGormilhit
Copy link

The route is wrong. It adds the collection URL to the document detail view URL.

@iGormilhit iGormilhit changed the title Document: the temporary location link doesn't work Document: the temporary location URL (route) is wrong Aug 30, 2021
@pronguen pronguen added this to the v1.6.0 milestone Sep 21, 2021
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Sep 29, 2021
@Garfield-fr
document: fix wrong url on collection
7c80d46 
* Closes rero/rero-ils#2337

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue Sep 29, 2021
Merged
7 tasks
@Garfield-fr Garfield-fr self-assigned this Sep 29, 2021
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Sep 29, 2021
@Garfield-fr
documents: fix wrong URL on collection
2390453 
* Closes rero/rero-ils#2337.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
iGormilhit pushed a commit to rero/rero-ils-ui that referenced this issue Oct 6, 2021
@Garfield-fr
documents: fix wrong URL on collection
20a23e1 
* Closes rero/rero-ils#2337.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
bug Breaks something but is not blocking f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

document: fix wrong URL on collection Garfield-fr/rero-ils-ui
4 participants
@Garfield-fr @iGormilhit @pronguen @ManaDeweerdt