Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request on an item which is checked out #235

Closed
pronguen opened this issue Mar 20, 2019 · 3 comments
Closed

Request on an item which is checked out #235

pronguen opened this issue Mar 20, 2019 · 3 comments
Assignees
Labels
f: circulation Concerns the circulation interface or backend

Comments

@pronguen
Copy link
Contributor

pronguen commented Mar 20, 2019

When a request is done on an item that is checked out, the request should not be displayed in the list of pending requests to validate.
When the check-in/receive of this item is done in the pick-up library, the status should not be "on_shelf", it should be "at the loan desk".

@pronguen pronguen added bug f: circulation Concerns the circulation interface or backend labels Mar 20, 2019
@pronguen pronguen changed the title Check-in of an item with a request: wrong status Request on an item which is checked out Mar 20, 2019
@BadrAly
Copy link

BadrAly commented Mar 20, 2019

1- unable to duplicate point number one using the following workflow:
login as:
Müller, Astrid @ library : Bibliothèque du Lycée de la Vallée d'Aoste
checked-out item item_barcode = 10000000019 to patron Simonetta/ Casalini: 2050124311
re-login as : reroilstest+philippe@gmail.com and request item_barcode = 10000000019
re-login as Müller, Astrid @ library : Bibliothèque du Lycée de la Vallée d'Aoste
item is not showing on http://localhost:5000/admin/circulation/requests

  1. for the second point, i was able to duplicate.
    however, the status can be correctly displayed in these two cases:
  • if you click the requests tab ,
  • if you clear the Checkin/Checkout tab and re-scan the item barcode

@pronguen
Copy link
Contributor Author

login as:
Müller, Astrid @ library : Bibliothèque cantonale valdôtaine, site d'Aoste
checked-out item item_barcode = 10000018384 (item type:standard) to patron Smith/John: 2000000001
re-login as : reroilstest+helder@gmail.com and request item_barcode = 10000018384 (pick-up location: Bibliothèque cantonale valdôtaine, site d'Aoste)
re-login as Müller, Astrid @ library : Bibliothèque cantonale valdôtaine, site d'Aoste
Check-in item_barcode = 10000018384

Result:

  1. Item is "on_shelf" with a request
  2. Item appears in the list of the pending requests.
  3. Helder didn't receive any notification

BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue May 6, 2019
* FIX Fixes rero#235: automatic validation for checked-in items at requested location.
* FIX Fixes rero#58: libraian notified after check-in of a requested item.

Signed-off-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue May 6, 2019
* FIX Fixes rero#235: automatic validation for checked-in items at requested location.
* FIX Fixes rero#58: libraian notified after check-in of a requested item.

Signed-off-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue May 7, 2019
* FIX Fixes rero#235: automatic validation for checked-in items at requested location.
* FIX Fixes rero#58: libraian notified after check-in of a requested item.

Signed-off-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly self-assigned this May 7, 2019
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue May 8, 2019
* FIX Fixes rero#235: automatic validation for checked-in items at requested location.
* FIX Fixes rero#58: libraian notified after check-in of a requested item.

Signed-off-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue May 9, 2019
* FIX Fixes rero#235: automatic validation for checked-in items at requested location.
* FIX Fixes rero#58: libraian notified after check-in of a requested item.

Signed-off-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue May 9, 2019
* FIX Fixes rero#235: automatic validation for checked-in items at requested location.
* FIX Fixes rero#58: libraian notified after check-in of a requested item.

Signed-off-by: Aly Badr <aly.badr@rero.ch>
jma pushed a commit that referenced this issue May 9, 2019
* FIX Fixes #235: automatic validation for checked-in items at requested location.
* FIX Fixes #58: libraian notified after check-in of a requested item.

Signed-off-by: Aly Badr <aly.badr@rero.ch>
@iGormilhit
Copy link

iGormilhit commented May 15, 2019

I think this is not ok, because as I tested it, the patron that requested the item being checked in don't get any email.

I am been informed that this will be checked when addressing the future notifications user story.

@jma jma closed this as completed in 32f33cf May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: circulation Concerns the circulation interface or backend
Projects
None yet
Development

No branches or pull requests

3 participants