Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Availability sent to the owning library instead of the pickup #2373

Closed
iGormilhit opened this issue Sep 8, 2021 · 0 comments · Fixed by #2393
Closed

Availability sent to the owning library instead of the pickup #2373

iGormilhit opened this issue Sep 8, 2021 · 0 comments · Fixed by #2393
Assignees
@zannkukai
Labels
bug Breaks something but is not blocking f: notifications p-High High priority (to be solved in the 2-3 next months)
Milestone
v1.6.0

Comments

@iGormilhit
Copy link

Describe the bug

If a patron with mail as communication channel, requested an item that is getting the status item at desk, the availability notice is sent to the library that owns the item, instead of the pickup library.

To Reproduce

  1. Go to https://ils.test.rero.ch.
  2. Log in as a patron.
  3. Verify that the communication channel is mail (not e-mail).
  4. In another tab or browser, log in as a system librarian (Astrid).
  5. Search for a patron that has borrowed items and select one of them.
  6. With the patron of point 2, request this item, with a pickup != from the owning.
  7. With the system librarian, verify the notification settings of both libraries, in order to know to with e-mail the notifications are supposed to be sent.
  8. Return the item in the pickup location. It's now item at desk.
  9. Verify that the request notification is sent to the library where the item has been returned.
  10. Verify that the availability notification is wrongly sent to the library that owns the item.

Expected behavior

The availability notification should be sent to the pickup library.

Context
@iGormilhit iGormilhit added f: notifications bug Breaks something but is not blocking p-High High priority (to be solved in the 2-3 next months) labels Sep 8, 2021
@pronguen pronguen modified the milestones: v1.5.0, v1.6.0 Sep 21, 2021
@zannkukai zannkukai linked a pull request Oct 4, 2021 that will close this issue
notifications: generalize notification resource #2393
Merged
7 tasks
@zannkukai zannkukai self-assigned this Oct 4, 2021
@zannkukai zannkukai mentioned this issue Oct 4, 2021
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 7, 2021
@zannkukai
notifications: generalize notification resource
93134a8 
This refactoring purpose is to generalize the notification system in order
to manage every kind of notification. The `Notification` resource
structure is heavy linked to circulation operation (we need to link the
notification with a loan).

This commit implements a specific class implementation for each type of
notification, with a subclass that provides relevant information to
process and dispatch the notification.

Closes rero#2373.
Closes rero#2390.
Closes rero#2410.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 11, 2021
@zannkukai
notifications: generalize notification resource
4f45280 
This refactoring purpose is to generalize the notification system in order
to manage every kind of notification. The `Notification` resource
structure is heavy linked to circulation operation (we need to link the
notification with a loan).

This commit implements a specific class implementation for each type of
notification, with a subclass that provides relevant information to
process and dispatch the notification.

Closes rero#2373.
Closes rero#2390.
Closes rero#2410.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 12, 2021
@zannkukai
notifications: generalize notification resource
8764996 
This refactoring purpose is to generalize the notification system in order
to manage every kind of notification. The `Notification` resource
structure is heavy linked to circulation operation (we need to link the
notification with a loan).

This commit implements a specific class implementation for each type of
notification, with a subclass that provides relevant information to
process and dispatch the notification.

Closes rero#2373.
Closes rero#2390.
Closes rero#2410.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 12, 2021
@zannkukai
notifications: generalize notification resource
ecf3e13 
This refactoring purpose is to generalize the notification system in order
to manage every kind of notification. The `Notification` resource
structure is heavy linked to circulation operation (we need to link the
notification with a loan).

This commit implements a specific class implementation for each type of
notification, with a subclass that provides relevant information to
process and dispatch the notification.

Closes rero#2373.
Closes rero#2390.
Closes rero#2410.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 12, 2021
@zannkukai
notifications: generalize notification resource
88e3922 
This refactoring purpose is to generalize the notification system in order
to manage every kind of notification. The `Notification` resource
structure is heavy linked to circulation operation (we need to link the
notification with a loan).

This commit implements a specific class implementation for each type of
notification, with a subclass that provides relevant information to
process and dispatch the notification.

Closes rero#2373.
Closes rero#2390.
Closes rero#2410.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 13, 2021
@zannkukai
notifications: generalize notification resource
0481872 
This refactoring purpose is to generalize the notification system in order
to manage every kind of notification. The `Notification` resource
structure is heavy linked to circulation operation (we need to link the
notification with a loan).

This commit implements a specific class implementation for each type of
notification, with a subclass that provides relevant information to
process and dispatch the notification.

Closes rero#2373.
Closes rero#2390.
Closes rero#2410.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue Oct 13, 2021
@zannkukai
notifications: generalize notification resource
f5bc227 
This refactoring purpose is to generalize the notification system in order
to manage every kind of notification. The `Notification` resource
structure is heavy linked to circulation operation (we need to link the
notification with a loan).

This commit implements a specific class implementation for each type of
notification, with a subclass that provides relevant information to
process and dispatch the notification.

Closes #2373.
Closes #2390.
Closes #2410.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking f: notifications p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

notifications: generalize notification resource zannkukai/rero-ils
3 participants
@iGormilhit @pronguen @zannkukai