Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search diacritics issues: économie vs economie #2396

Closed
ManaDeweerdt opened this issue Sep 21, 2021 · 0 comments · Fixed by #2387
Closed

Search diacritics issues: économie vs economie #2396

ManaDeweerdt opened this issue Sep 21, 2021 · 0 comments · Fixed by #2387
Assignees
@Garfield-fr
Labels
bug Breaks something but is not blocking f: public ui Public interface, as opposed to the professional interface f: search p-High High priority (to be solved in the 2-3 next months)
Milestone
v1.6.0

Comments

@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Sep 21, 2021 •
edited by iGormilhit
Loading

Describe the bug

The results are different if we search for a title with or without diacritics.
Additionally, if we type a title with diacritics, the autocomplete doesn't find it.

To Reproduce

  1. Search 'économie" or "economie"
  2. See the difference.
  3. For the autocomplete, type 'Manuel de recherche préhistorique" or 'Manuel de recherche prehistorique' in the search box.

Expected behavior

  1. As a user types a term with diacritics, the autocomplete should propose the apparent title (public interface, editor...).
  2. The results number should be the same either we search for 'économie' or 'economie'.

Context
@ManaDeweerdt ManaDeweerdt added f: public ui Public interface, as opposed to the professional interface triage bug Breaks something but is not blocking p-Low Low priority labels Sep 21, 2021
@pronguen pronguen added this to the v1.6.0 milestone Sep 21, 2021
@ManaDeweerdt ManaDeweerdt changed the title Diachritics issues : économie vs economie Diacritics issues : économie vs economie Sep 21, 2021
@ManaDeweerdt ManaDeweerdt added p-Medium Medium priority (to be solved within 1-2 years) and removed p-Low Low priority labels Sep 21, 2021
@pronguen pronguen added f: search p-High High priority (to be solved in the 2-3 next months) and removed triage labels Sep 21, 2021
@iGormilhit iGormilhit changed the title Diacritics issues : économie vs economie Search diacritics issues: économie vs economie Sep 22, 2021
@iGormilhit iGormilhit removed the p-Medium Medium priority (to be solved within 1-2 years) label Sep 22, 2021
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 28, 2021
@Garfield-fr
Implement stop words
c23e3b1 
* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 28, 2021
@Garfield-fr
data: implement stop words
172a585 
* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 28, 2021
@Garfield-fr
data: implement stop words
8899172 
* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue Sep 28, 2021
Merged
7 tasks
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 28, 2021
@Garfield-fr
data: implement stop words
d7f0e08 
* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 28, 2021
@Garfield-fr
data: implement stop words
09c74c8 
* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 28, 2021
@Garfield-fr @jma
data: implement stop words
cb34089 
* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 28, 2021
@Garfield-fr @jma
data: implement stop words
7b1a47e 
* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 29, 2021
@Garfield-fr @jma
data: implement stop words
8b61209 
* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Adds language mapping for code conversion.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 29, 2021
@Garfield-fr @jma
data: implement stop words
b22b609 
* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Adds language mapping for code conversion.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 29, 2021
@Garfield-fr @jma
data: implement stop words
6443cfd 
* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Adds language mapping for code conversion.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 29, 2021
@Garfield-fr @jma
data: implement stop words
28a1d21 
* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Adds language mapping for code conversion.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 29, 2021
@Garfield-fr @jma
data: implement stop words
dd8d499 
* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Adds language mapping for code conversion.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 29, 2021
@Garfield-fr @jma
data: implement stop words
ec1a680 
* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Adds language mapping for code conversion.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 29, 2021
@Garfield-fr @jma
data: implement stop words
9c6d52a 
Warning: reindexing documents and contributions is mandatory.

* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Adds language mapping for code conversion.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 30, 2021
@Garfield-fr @jma
data: implement stop words
1669879 
Warning: reindexing documents and contributions is mandatory.

* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Adds language mapping for code conversion.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
@Garfield-fr Garfield-fr self-assigned this Sep 30, 2021
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Oct 5, 2021
@Garfield-fr @jma
data: implement stop words
d73bd44 
Warning: reindexing documents and contributions is mandatory.

* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Adds language mapping for code conversion.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Oct 5, 2021
@Garfield-fr @jma
data: implement stop words
a245440 
Warning: reindexing documents and contributions is mandatory.

* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Adds language mapping for code conversion.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Oct 6, 2021
@Garfield-fr @jma
data: implement stop words
b8e58dc 
Warning: reindexing documents and contributions is mandatory.

* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Adds language mapping for code conversion.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Oct 6, 2021
@Garfield-fr @jma
data: implement stop words
a2911a4 
Warning: reindexing documents and contributions is mandatory.

* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Adds language mapping for code conversion.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Oct 6, 2021
@Garfield-fr @jma
data: implement stop words
8d7cb96 
Warning: reindexing documents and contributions is mandatory.

* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Adds language mapping for code conversion.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Oct 6, 2021
@Garfield-fr @jma
data: implement stop words
1df27f6 
Warning: reindexing documents and contributions is mandatory.

* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Adds language mapping for code conversion.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Oct 6, 2021
@Garfield-fr @jma
data: implement stop words
a9cc045 
Warning: reindexing documents and contributions is mandatory.

* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Adds language mapping for code conversion.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Oct 7, 2021
@Garfield-fr @jma
data: implement stop words
8b69212 
Warning: reindexing documents, contributions and patrons is mandatory.

* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Adds language mapping for code conversion.
* Fixes generating the document title on _text.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Oct 7, 2021
@Garfield-fr @jma
data: implement stop words
564e13f 
Warning: reindexing documents, contributions and patrons is mandatory.

* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Adds language mapping for code conversion.
* Fixes generating the document title on _text.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Oct 7, 2021
@Garfield-fr @jma
data: implement stop words
8980371 
Warning: reindexing documents, contributions and patrons is mandatory.

* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Adds language mapping for code conversion.
* Fixes generating the document title on _text.
* Closes rero#2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit that referenced this issue Oct 13, 2021
@Garfield-fr @jma
data: implement stop words
c4bdd9e 
Warning: reindexing documents, contributions and patrons is mandatory.

* Adds a stop word based normalizer.
* Adds fields on the documents for sorting.
* Adds fields on the contributions for sorting.
* Adds elasticsearch configuration for sorting on resources.
* Adds language mapping for code conversion.
* Fixes generating the document title on _text.
* Closes #2396.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
bug Breaks something but is not blocking f: public ui Public interface, as opposed to the professional interface f: search p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

data: implement stop words Garfield-fr/rero-ils
4 participants
@Garfield-fr @iGormilhit @pronguen @ManaDeweerdt