Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Availability of serials (at the document level) should be "See collections and items" if a serial holding is attached #2502

Open
JoelleDosimont opened this issue Nov 4, 2021 · 4 comments · Fixed by rero/rero-ils-ui#786
Open

Availability of serials (at the document level) should be "See collections and items" if a serial holding is attached #2502

JoelleDosimont opened this issue Nov 4, 2021 · 4 comments · Fixed by rero/rero-ils-ui#786
Assignees
@zannkukai
Labels
correction An implemented feature doesn't work as expected. f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface f: serials
Milestone
v1.9.0

Comments

@JoelleDosimont
Copy link
Contributor

JoelleDosimont commented Nov 4, 2021 •
edited by pronguen
Loading

Describe the bug

In the pro and public interface:

  • At the document level, if a serial has no item attached, the availability is set to "not available". It should be orange with text "See items and collections".
  • Serial holdings without items are not expandable when more than 1 holdings is displayed, but they are if only 1 holdings is displayed.

To Reproduce

  1. Search for serials with a holdings, but no item (ex. : Paroisses vivantes : bulletin des paroisses catholiques romandes)
  2. See that at the document level it's "not available"

Expected behavior

Context

Screenshots

Wrong document simple availability
image

Serial holdings without items sometimes expandable with "No items received", sometimes not.
image
@JoelleDosimont JoelleDosimont added f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface triage bug Breaks something but is not blocking f: serials p-Medium Medium priority (to be solved within 1-2 years) labels Nov 4, 2021
@iGormilhit iGormilhit added correction and removed bug Breaks something but is not blocking triage labels Nov 8, 2021
@pronguen
Copy link
Contributor

Linked to #2278

@pronguen pronguen added this to the v1.9.0 milestone Nov 30, 2021
@pronguen pronguen modified the milestones: v1.9.0, v1.8.0 Dec 16, 2021
@zannkukai zannkukai self-assigned this Jan 13, 2022
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jan 13, 2022
@zannkukai
holdings: fix item collapsing.
108adb5 
Always collapse/hide items related to a serial holding in the document
detail view.
Closes rero/rero-ils#2502.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Jan 13, 2022
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jan 13, 2022
@zannkukai
holdings: fix item collapsing.
c496d9d 
Always collapse/hide items related to a serial holding in the document
detail view.
Closes rero/rero-ils#2502.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jan 19, 2022
@zannkukai
holdings: fix item collapsing.
ebac7cb 
Always collapse/hide items related to a serial holding in the document
detail view.
Closes rero/rero-ils#2502.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jan 19, 2022
@zannkukai
holdings: fix item collapsing.
321533b 
Always collapse/hide items related to a serial holding in the document
detail view.
Closes rero/rero-ils#2502.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@pronguen pronguen reopened this Feb 21, 2022
@pronguen pronguen modified the milestones: v1.8.0, v1.9.0 Feb 21, 2022
@PascalRepond PascalRepond added bug Breaks something but is not blocking and removed class: correction labels Feb 21, 2022
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Feb 22, 2022
@zannkukai
holdings: fix item collapsing
e61e6fc 
Closes rero/rero-ils#2502.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Feb 22, 2022
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Feb 22, 2022
@zannkukai
holdings: fix item collapsing
fe5c88a 
Closes rero/rero-ils#2502.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@ManaDeweerdt ManaDeweerdt mentioned this issue Mar 3, 2022
Merged
7 tasks
@PascalRepond
Copy link
Contributor

Reopening this as it is not fixed yet.

@PascalRepond PascalRepond reopened this Apr 14, 2022
@PascalRepond PascalRepond reopened this May 30, 2022
@PascalRepond PascalRepond added correction An implemented feature doesn't work as expected. and removed bug Breaks something but is not blocking labels May 30, 2022
@PascalRepond PascalRepond reopened this Jun 30, 2022
@github-actions
Copy link

This issue is stale because it has been open 6 months with no activity.

@github-actions github-actions bot added the stale Stale or no longer relevant label Dec 28, 2022
@PascalRepond PascalRepond reopened this Dec 28, 2022
@PascalRepond PascalRepond removed the stale Stale or no longer relevant label Dec 28, 2022
@PascalRepond PascalRepond removed the p-Medium Medium priority (to be solved within 1-2 years) label Mar 30, 2023
@PascalRepond PascalRepond moved this to Inbox in RERO ILS issues Mar 30, 2023
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues Aug 21, 2023
@JoelleDosimont JoelleDosimont mentioned this issue Aug 31, 2023
Merged
@github-actions
Copy link

This issue is stale because it has been open 6 months with no activity.

@github-actions github-actions bot added the stale Stale or no longer relevant label Sep 28, 2023
@PascalRepond PascalRepond removed the stale Stale or no longer relevant label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
correction An implemented feature doesn't work as expected. f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface f: serials
Projects
RERO ILS issues
Status: Product Backlog
Milestone
v1.9.0
Development

Successfully merging a pull request may close this issue.

holdings: fix item collapsing. zannkukai/rero-ils-ui
5 participants
@iGormilhit @pronguen @zannkukai @PascalRepond @JoelleDosimont