Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subjects from MEF are not displayed correctly in facet / document detailed view #2609

Closed
pronguen opened this issue Dec 20, 2021 · 5 comments · Fixed by #2808
Closed

Subjects from MEF are not displayed correctly in facet / document detailed view #2609

pronguen opened this issue Dec 20, 2021 · 5 comments · Fixed by #2808
Assignees
@zannkukai
Labels
client request Issue reported by production libraries correction An implemented feature doesn't work as expected. f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years)

Comments

@pronguen
Copy link
Contributor

pronguen commented Dec 20, 2021 •
edited
Loading

How it works

MEF subject are not displayed in the same way than MEF contributors:
image

MEF subjects are not present in the subject facet:
image

How it should works

In the public and professional interfaces, document detailed view + document subject facet:

  • Subjects from MEF are displayed in the same way than MEF contributors (same logic: multilingual, etc.)
    • They are clickable.
  • Local subjects are displayed as follow
    • Field preferred_name for types bf:Place, bf:Person, bf:Organization
    • Field title / creator for type bf:Work
    • Field term for type bf:Topic, bf:Temporal
    • Ideally, the subjects are sorted by types for the display.
@pronguen pronguen added f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface correction p-Medium Medium priority (to be solved within 1-2 years) labels Dec 20, 2021
@PascalRepond PascalRepond added bug Breaks something but is not blocking and removed class: correction labels Feb 21, 2022
@PascalRepond PascalRepond added the client request Issue reported by production libraries label Mar 8, 2022
@PascalRepond PascalRepond added correction An implemented feature doesn't work as expected. and removed bug Breaks something but is not blocking labels Mar 18, 2022
@ManaDeweerdt
Copy link
Contributor

Duplicate with #2354 ?

@PascalRepond
Copy link
Contributor

@ManaDeweerdt Yes. I close the other one since this one is more detailed. Thank you for the heads-up.

@PascalRepond PascalRepond mentioned this issue Mar 31, 2022
Closed
@ManaDeweerdt
Copy link
Contributor

@ManaDeweerdt Yes. I close the other one since this one is more detailed. Thank you for the heads-up.

Maybe this one too? #1869

zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 1, 2022
@zannkukai
document: subjects subdivision
8efee14 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Apr 1, 2022
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 1, 2022
@zannkukai
document: subjects subdivision
bc9106d 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 2, 2022
@zannkukai
document: subjects subdivision
5d661a2 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 3, 2022
@zannkukai
document: subjects subdivision
f5cf1f1 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 3, 2022
@zannkukai
document: subjects subdivision
662c757 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@pronguen pronguen mentioned this issue Apr 19, 2022
Closed
zannkukai added a commit that referenced this issue Apr 21, 2022
@zannkukai
document: subjects subdivision
69c25c2 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes #2455.
Closes #2609.
Closes #1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue Apr 21, 2022
@zannkukai
document: subjects subdivision
80a2b04 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes #2455.
Closes #2609.
Closes #1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@PascalRepond PascalRepond mentioned this issue Apr 26, 2022
Closed
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 28, 2022
@zannkukai
document: subjects subdivision
7f83925 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 28, 2022
@zannkukai
document: subjects subdivision
5de77fe 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 28, 2022
@zannkukai
document: subjects subdivision
3462b98 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue May 4, 2022
@zannkukai
document: subjects subdivision
a90b917 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes #2455.
Closes #2609.
Closes #1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 4, 2022
@zannkukai
document: subjects subdivision
dbb0d26 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 5, 2022
@zannkukai
document: subjects subdivision
ad2241f 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 5, 2022
@zannkukai
document: subjects subdivision
22aef53 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue May 5, 2022
@zannkukai
document: subjects subdivision
5c1e1b5 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes #2455.
Closes #2609.
Closes #1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 6, 2022
@zannkukai
document: subjects subdivision
15ea7d1 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue May 9, 2022
@zannkukai
document: subjects subdivision
9fcf2e9 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes #2455.
Closes #2609.
Closes #1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@pronguen
Copy link
Contributor Author

I reopen it because MEF persons are still not present in the subject facet.

@pronguen pronguen reopened this May 24, 2022
@pronguen pronguen changed the title Subjects from MEF are not displayed correctly in document detailed view Subjects from MEF are not displayed correctly in facet / document detailed view May 24, 2022
@pronguen
Copy link
Contributor Author

I re-close it in profit of this one: #2814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
client request Issue reported by production libraries correction An implemented feature doesn't work as expected. f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

document: subjects subdivision zannkukai/rero-ils
4 participants
@pronguen @zannkukai @ManaDeweerdt @PascalRepond