Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E-mail validation must be stricter #2838

Closed
pronguen opened this issue Apr 11, 2022 · 1 comment · Fixed by #2861
Closed

E-mail validation must be stricter #2838

pronguen opened this issue Apr 11, 2022 · 1 comment · Fixed by #2861
Assignees
@zannkukai
Labels
enhancement Improvement of an existing feature f: user management p-Low Low priority

Comments

@pronguen
Copy link
Contributor

pronguen commented Apr 11, 2022 •
edited
Loading

How it works

It is possible to enter wrong formatted e-mails into RERO ILS for users/patrons.

Improvement suggestion

In the user editor, professional view (user e-mail + patron additional communication e-mail) + in the public view (user e-mail), the validation should be stricter:

  • no spaces in the beginning or the end (or they are automatically trimmed)
  • no spaces in the e-mail
  • no dot at the end, or other punctuation character
  • only one @
  • eventually the system checks if the domain name exists
@pronguen pronguen added enhancement Improvement of an existing feature p-Low Low priority f: user management labels Apr 11, 2022
@PascalRepond
Copy link
Contributor

Linked to #2765

@zannkukai zannkukai self-assigned this Apr 22, 2022
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 27, 2022
@zannkukai
resource: improve data validation against JSONSchema
8bfeae8 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Apr 27, 2022
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 28, 2022
@zannkukai
resource: improve data validation against JSONSchema
e38eed8 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 4, 2022
@zannkukai
resource: improve data validation against JSONSchema
6456377 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 4, 2022
@zannkukai
resource: improve data validation against JSONSchema
57a691b 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 16, 2022
@zannkukai
resource: improve data validation against JSONSchema
4b4a553 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 16, 2022
@zannkukai
resource: improve data validation against JSONSchema
aaab120 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 16, 2022
@zannkukai
resource: improve data validation against JSONSchema
19eba83 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 17, 2022
@zannkukai
resource: improve data validation against JSONSchema
168f0f7 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 17, 2022
@zannkukai
resource: improve data validation against JSONSchema
ccdbb82 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 20, 2022
@zannkukai
resource: improve data validation against JSONSchema
6c87df9 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue May 25, 2022
@zannkukai
resource: improve data validation against JSONSchema
b1430ed 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes #2765.
* Closes #2838.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 31, 2022
@zannkukai
resource: improve data validation against JSONSchema
ae96a49 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue May 31, 2022
@zannkukai
resource: improve data validation against JSONSchema
ba23be1 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes #2765.
* Closes #2838.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 31, 2022
@zannkukai
resource: improve data validation against JSONSchema
932a475 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue Jun 1, 2022
@zannkukai
resource: improve data validation against JSONSchema
6ad32e1 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes #2765.
* Closes #2838.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
enhancement Improvement of an existing feature f: user management p-Low Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resource: improve data validation against JSONSchema zannkukai/rero-ils
3 participants
@pronguen @zannkukai @PascalRepond