Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Items (UI) : rtsp procole is flagged as "unsafe" by Angular #2893

Closed
benerken opened this issue May 10, 2022 · 0 comments · Fixed by rero/rero-ils-ui#857
Closed

Items (UI) : rtsp procole is flagged as "unsafe" by Angular #2893

benerken opened this issue May 10, 2022 · 0 comments · Fixed by rero/rero-ils-ui#857
Assignees
@zannkukai
Labels
bug Breaks something but is not blocking effort: minor Solved quickly enhancement Improvement of an existing feature

Comments

@benerken
Copy link
Contributor

benerken commented May 10, 2022 •
edited
Loading

Bug description:

In the professional view or in public view, an item with URL starting with rtsp protocole (rtsp://)
is flagged as "unsafe" when the view is generated by the angular component. So, the link doesn't work !

Expected behavior:

An URL starting with rtsp protocole should work correctly when the user click on it.

Steps to Reproduce:

  1. Go to ilsdev and login as Astrid. Go to the professional view
  2. Take an existing document and create a new item, with an URL starting with rtsp:// . Save it.
  3. Check the link displayed and try to click on it. It doesn't work.
  4. At the bottom of the screen, you see "unsafe:rtsp://...."

Context

Linked to Issue #2892

Server:

Version:
RERO-ILS v1.10

Screenshots

image
@benerken benerken added the bug Breaks something but is not blocking label May 10, 2022
@benerken benerken mentioned this issue May 10, 2022
Closed
1 task
@benerken benerken added enhancement Improvement of an existing feature effort: minor Solved quickly labels May 10, 2022
@zannkukai zannkukai self-assigned this May 24, 2022
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue May 24, 2022
@zannkukai
general: Safe URL pipe
f139480 
Allow to specify that URL are safe. In this case, Angular doesn't add an
"unsafe:" protocol string on the href link.

Closes rero/rero-ils#2893.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue May 24, 2022
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue May 24, 2022
@zannkukai
general: Safe URL pipe
74aacec 
Allow to specify that URL are safe. In this case, Angular doesn't add an
"unsafe:" protocol string on the href link.

Closes rero/rero-ils#2893.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to rero/rero-ils-ui that referenced this issue May 25, 2022
@zannkukai
general: Safe URL pipe
7f9c084 
Allow to specify that URL are safe. In this case, Angular doesn't add an
"unsafe:" protocol string on the href link.

Closes rero/rero-ils#2893.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to rero/rero-ils-ui that referenced this issue May 31, 2022
@zannkukai
general: Safe URL pipe
972884d 
Allow to specify that URL are safe. In this case, Angular doesn't add an
"unsafe:" protocol string on the href link.

Closes rero/rero-ils#2893.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking effort: minor Solved quickly enhancement Improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

general: Safe URL pipe zannkukai/rero-ils-ui
2 participants
@zannkukai @benerken