Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public view: The layout should change after expanding the result to global view #3136

Closed
ManaDeweerdt opened this issue Oct 12, 2022 · 0 comments · Fixed by rero/rero-ils-ui#1042
Closed

Public view: The layout should change after expanding the result to global view #3136

ManaDeweerdt opened this issue Oct 12, 2022 · 0 comments · Fixed by rero/rero-ils-ui#1042
Assignees
@Garfield-fr
Labels
correction An implemented feature doesn't work as expected. f: public ui Public interface, as opposed to the professional interface

Comments

@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Oct 12, 2022 •
edited
Loading

Bug description:

On an organisational view, when we expand the result to all RERO ILS, the url changes to 'global' (ok) but the layout is not updated. (cf. screenshot)
Note: when we click on the item, the banner/header of the detailed view is correct.

Expected behavior:

As we expand the result to all RERO ILS, we are redirected to the global view and the banner/header is updated.

Steps to Reproduce:

  1. Go to an organizational view. Search for an item not available in the organisation. Ex on ils.dev: https://ilsdev.test.rero.ch/fictive/search/documents?q=From%20Evanston%20to%20Delhi&page=1&size=10&sort=bestmatch
  2. Expand the result

Context

Server:

Version:

v1.13.0 ; commit hash : XXXX

Browser:

Chrome, Safari, Firefox; version XX

Screenshots

https://ilsdev.test.rero.ch/fictive/search/documents?q=From%20Evanston%20to%20Delhi&page=1&size=10&sort=bestmatch
image

https://ilsdev.test.rero.ch/global/search/documents?q=From%20Evanston%20to%20Delhi&page=1&size=10&sort=bestmatch
image

image
@ManaDeweerdt ManaDeweerdt added f: search f: public ui Public interface, as opposed to the professional interface p-Low Low priority correction An implemented feature doesn't work as expected. labels Oct 12, 2022
@ManaDeweerdt ManaDeweerdt changed the title The navigation bar/header should change after expanding the result to all RERO ILS The layout should change after expanding the result to all RERO ILS Oct 12, 2022
@benerken benerken changed the title The layout should change after expanding the result to all RERO ILS public view: The layout should change after expanding the result to all RERO ILS Oct 12, 2022
@benerken benerken changed the title public view: The layout should change after expanding the result to all RERO ILS Public view: The layout should change after expanding the result to all RERO ILS Oct 12, 2022
@benerken benerken changed the title Public view: The layout should change after expanding the result to all RERO ILS Public view: The layout should change after expanding the result to global view Oct 12, 2022
@PascalRepond PascalRepond removed f: search p-Low Low priority labels Mar 30, 2023
@PascalRepond PascalRepond moved this to Project Backlog in RERO ILS issues Mar 30, 2023
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Sep 21, 2023
@Garfield-fr
document: fix expand to global view
66c96ea 
* Closes rero/rero-ils#3136.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Sep 21, 2023
@Garfield-fr
document: fix expand to global view
8e7a384 
* Closes rero/rero-ils#3136.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue Sep 21, 2023
Merged
7 tasks
@Garfield-fr Garfield-fr moved this from Product Backlog to Ready to test in RERO ILS issues Sep 21, 2023
@Garfield-fr Garfield-fr moved this from Ready to test to In Development in RERO ILS issues Sep 21, 2023
@Garfield-fr Garfield-fr self-assigned this Sep 21, 2023
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Sep 21, 2023
@Garfield-fr
document: fix expand to global view
96ff37b 
* Closes rero/rero-ils#3136.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr moved this from In Development to Ready to test in RERO ILS issues Sep 21, 2023
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Sep 28, 2023
@Garfield-fr
document: fix expand to global view
c728890 
* Closes rero/rero-ils#3136.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@PascalRepond PascalRepond moved this from Ready to test to In testing in RERO ILS issues Sep 28, 2023
@PascalRepond PascalRepond moved this from In testing to Approved in RERO ILS issues Oct 2, 2023
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Oct 2, 2023
@Garfield-fr
document: fix expand to global view
c363f84 
* Closes rero/rero-ils#3136.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Oct 3, 2023
@Garfield-fr
document: fix expand to global view
c838935 
* Closes rero/rero-ils#3136.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Oct 3, 2023
@Garfield-fr
document: fix expand to global view
55a8301 
* Closes rero/rero-ils#3136.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@github-project-automation github-project-automation bot moved this from Approved to Done in RERO ILS issues Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
correction An implemented feature doesn't work as expected. f: public ui Public interface, as opposed to the professional interface
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

document: fix expand to global view Garfield-fr/rero-ils-ui
3 participants
@Garfield-fr @ManaDeweerdt @PascalRepond