Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loans are displayed twice in the loan history #3469

Closed
PascalRepond opened this issue Sep 27, 2023 · 0 comments · Fixed by rero/rero-ils-ui#1047
Closed

Loans are displayed twice in the loan history #3469

PascalRepond opened this issue Sep 27, 2023 · 0 comments · Fixed by rero/rero-ils-ui#1047
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries f: circulation Concerns the circulation interface or backend f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface

Comments

@PascalRepond
Copy link
Contributor

PascalRepond commented Sep 27, 2023 •
edited
Loading

Bug description:

Since v1.18.0, the loans list in the patron history (pro UI AND public UI) shows all loans twice. Moreover, in the pro UI, there are some display bugs and errors in the javascript console. See: https://ils.test.rero.ch/professional/circulation/patron/kad001/history

Analysis

These views use the operation logs to list certain type of loans but they don't filter on the field record.type=loan, which also return operation logs of type "notif" since v1.18.0!

Expected behavior:

Loans in the history should only be shown once and there should be no errors on this page.

Steps to Reproduce:

  1. Go to https://ils.test.rero.ch/professional/circulation/patron/kad001/history

  2. See double lines for loans

  3. See JS error

  4. Got to https://ils.test.rero.ch/global/patrons/profile (logged in as Katie)

  5. See that loans are also doubled

Context

Server:

Version:

v1.18.0
@PascalRepond PascalRepond added f: circulation Concerns the circulation interface or backend f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface bug Breaks something but is not blocking client request Issue reported by production libraries labels Sep 27, 2023
@PascalRepond PascalRepond changed the title Loans ar shown twice in the loan history Loans are displayed twice in the loan history Sep 27, 2023
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues Sep 27, 2023
@PascalRepond PascalRepond moved this from Product Backlog to Sprint backlog in RERO ILS issues Oct 3, 2023
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Oct 3, 2023
@Garfield-fr
history: fix duplicate records.
8f1ccc5 
Added loan type filter to have only one type in the history.

* Closes rero/rero-ils#3469.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr moved this from Sprint backlog to Ready to test in RERO ILS issues Oct 3, 2023
@Garfield-fr Garfield-fr mentioned this issue Oct 3, 2023
Merged
7 tasks
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Oct 3, 2023
@Garfield-fr
history: fix duplicate records
6305f16 
Added loan type filter to have only one type in the history.

* Closes rero/rero-ils#3469.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Oct 4, 2023
@Garfield-fr
history: fix duplicate records
a29194e 
Added loan type filter to have only one type in the history.

* Closes rero/rero-ils#3469.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
PascalRepond pushed a commit to rero/rero-ils-ui that referenced this issue Oct 6, 2023
@Garfield-fr @PascalRepond
history: fix duplicate records
515f307 
Added loan type filter to have only one type in the history.

* Closes rero/rero-ils#3469.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@github-project-automation github-project-automation bot moved this from Ready to test to Done in RERO ILS issues Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries f: circulation Concerns the circulation interface or backend f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

history: fix duplicate records Garfield-fr/rero-ils-ui
1 participant
@PascalRepond