Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkin transit item sometimes doesn't show patron info #3612

Closed
PascalRepond opened this issue Feb 27, 2024 · 0 comments · Fixed by rero/rero-ils-ui#1124
Closed

Checkin transit item sometimes doesn't show patron info #3612

PascalRepond opened this issue Feb 27, 2024 · 0 comments · Fixed by rero/rero-ils-ui#1124
Assignees
@jma @PascalRepond
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries f: circulation Concerns the circulation interface or backend

Comments

@PascalRepond
Copy link
Contributor

PascalRepond commented Feb 27, 2024 •
edited
Loading

Bug description:

When checking in an item that becomes "at_desk", if the loan has been validated, the patron info is not displayed.

Expected behavior:

The patron info should be displayed under the item.status

Steps to Reproduce:

  1. Request an item for a patron in another library
  2. Validate the request
  3. Checkin the item in the pickup library
  4. See that the patron info and pickup location info is not displayed

Context

The UI is set to only show the item.status if there is no item.loan in the data returned by the backend. We should find why the item is returned without its loan in the case where it is scanned in the library of the pickup.
@PascalRepond PascalRepond added the bug Breaks something but is not blocking label Feb 27, 2024
@PascalRepond PascalRepond added f: circulation Concerns the circulation interface or backend client request Issue reported by production libraries labels Feb 27, 2024
@PascalRepond PascalRepond moved this from Inbox to Sprint backlog in RERO ILS issues Feb 27, 2024
@PascalRepond PascalRepond moved this from Sprint backlog to Product Backlog in RERO ILS issues Feb 27, 2024
@PascalRepond PascalRepond moved this from Product Backlog to In Development in RERO ILS issues Feb 27, 2024
@PascalRepond PascalRepond self-assigned this Feb 27, 2024
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Feb 27, 2024
@PascalRepond @jma
fix(circulation): no loan info on receive
650e9ec 
* When performing a receive action on a loan, the ui didn't append
the loan info and so the item could be treated as having no loan.
* Closes rero/rero-ils#3612.

Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond mentioned this issue Feb 27, 2024
Merged
@PascalRepond PascalRepond moved this from In Development to Ready to test in RERO ILS issues Feb 27, 2024
PascalRepond added a commit to rero/rero-ils-ui that referenced this issue Feb 28, 2024
@PascalRepond @jma
fix(circulation): no loan info on receive
18c5295 
* When performing a receive action on a loan, the ui didn't append
the loan info and so the item could be treated as having no loan.
* Closes rero/rero-ils#3612.

Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@github-project-automation github-project-automation bot moved this from Ready to test to Done in RERO ILS issues Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jma jma

@PascalRepond PascalRepond

Labels
bug Breaks something but is not blocking client request Issue reported by production libraries f: circulation Concerns the circulation interface or backend
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(circulation): no loan info on receive PascalRepond/rero-ils-ui
2 participants
@jma @PascalRepond