New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when displaying a loan if the item has been deleted #3710

Closed

PascalRepond opened this issue Jun 26, 2024 · 0 comments · Fixed by #3787

Assignees

Labels

bug dev: sentry

Contributor

PascalRepond commented Jun 26, 2024

Bug description:

If I delete an item that was linked to a loan, the serialization creates an error if I try to see the loan in the API.
Usually we don't use it but it still creates an error in the API.

Moreover, this can create problems in the interface when displaying past fees linked to this loan (error in the console).

Expected behavior:

The serialization for a loan should take into account that the item/document may not exist anymore and say "unknown" when it needs info that doesn't exist anymore OR implement soft delete

Steps to Reproduce:

Find a loan with a fee
Checkin the item and "pay" the fee
Delete the item
Go to the patron profile and check fee history /professional/circulation/patron/[pid]/fees
See console and Sentry error

Example: https://bib.rero.ch/api/loans/412553

PascalRepond added the bug label

github-project-automation bot added this to RERO ILS issues

github-project-automation bot moved this to Inbox in RERO ILS issues

PascalRepond added the dev: sentry label

PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues

rerowep self-assigned this

rerowep moved this from Product Backlog to In Development in RERO ILS issues

rerowep added a commit to rerowep/rero-ils that referenced this issue


          oauth: add patron pid

04cdd8c

* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep mentioned this issue

oauth: adds user_id and patron_info #3786

Merged

rerowep added a commit to rerowep/rero-ils that referenced this issue


          oauth: add patron pid

ea235a3

* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          oauth: add patron pid

f6bd22e

* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          oauth: add patron pid

ed906e9

* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          oauth: add patron pid

a3b19b7

* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          oauth: add patron pid

53cfb2f

* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          loan: fix organisation_pid function

25cba7a

* Closes rero#3710

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep mentioned this issue

loan: fix organisation_pid function #3787

Merged

rerowep moved this from In Development to Ready to test in RERO ILS issues

rerowep added a commit to rerowep/rero-ils that referenced this issue


          loan: fix organisation_pid function

a5e1188

* Closes rero#3710

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          loan: fix organisation_pid function

1412c08

* Closes rero#3710

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          oauth: add patron pid

bc8b1a7

* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          loan: fix organisation_pid function

8d1e077

* Closes rero#3710

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          oauth: add patron pid

0b21e8b

* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          loan: fix organisation_pid function

e64c256

* Closes rero#3710
* Cleans code for `organisation_pid` function.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          loan: fix organisation_pid function

* Closes rero#3710
* Cleans code for `organisation_pid` function.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          oauth: add patron pid

f8a271e

* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          loan: fix organisation_pid function

915427b

* Closes rero#3710
* Cleans code for `organisation_pid` function.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          oauth: add patron pid

* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          oauth: add patron pid

99797ca

* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          oauth: add patron pid

9e97bf0

* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          loan: fix organisation_pid function

9f957be

* Closes rero#3710
* Cleans code for `organisation_pid` function.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          loan: fix organisation_pid function

e71d7e1

* Closes rero#3710
* Cleans code for `organisation_pid` function.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

PascalRepond pushed a commit that referenced this issue


          oauth: add patron pid

f1cdf11

* Adds `patron_pid` to scope.
* Closes #3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

PascalRepond pushed a commit that referenced this issue


          loan: fix organisation_pid function

cef5c33

* Closes #3710
* Cleans code for `organisation_pid` function.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          oauth: add patron pid

cc77af3

* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          oauth: add patron pid

1df642a

* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          loan: fix organisation_pid function

7438c8e

* Closes rero#3710
* Cleans code for `organisation_pid` function.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit that referenced this issue


          oauth: add patron pid

d2a0b16

* Adds `patron_pid` to scope.
* Closes #3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit that referenced this issue


          loan: fix organisation_pid function

00f6bfc

* Closes #3710
* Cleans code for `organisation_pid` function.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          oauth: add patron pid

d2e7e19

* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          loan: fix organisation_pid function

cf967b5

* Closes rero#3710
* Cleans code for `organisation_pid` function.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit that referenced this issue


          oauth: add patron pid

478e9d8

* Adds `patron_pid` to scope.
* Closes #3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit that referenced this issue


          loan: fix organisation_pid function

b98b0bf

* Closes #3710
* Cleans code for `organisation_pid` function.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep added a commit to rerowep/rero-ils that referenced this issue


          oauth: add patron pid

9ff1ed1

* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

rerowep closed this as completed in #3787

rerowep added a commit that referenced this issue


          loan: fix organisation_pid function

95babd9

* Closes #3710
* Cleans code for `organisation_pid` function.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

github-project-automation bot moved this from Ready to test to Done in RERO ILS issues

rerowep added a commit to rerowep/rero-ils that referenced this issue


          oauth: add patron pid

7b1b605

* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment