Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acquisition receipt: Document without an identifier is not displayed correctly unless selected #3732

Closed
PascalRepond opened this issue Aug 8, 2024 · 0 comments · Fixed by rero/rero-ils-ui#1220
Closed

Acquisition receipt: Document without an identifier is not displayed correctly unless selected #3732

PascalRepond opened this issue Aug 8, 2024 · 0 comments · Fixed by rero/rero-ils-ui#1220
Assignees
@rerowep
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries UX User experience, ergonomy

Comments

@PascalRepond
Copy link
Contributor

Bug description:

If I try to create an acquisition receipt in an order linked to a document that has no field identifiedBy, the document info is not displayed on page load with an error in the console. It is only displayed if I select the line.

Expected behavior:

The document info should be displayed.

Steps to Reproduce:

  1. Create a document with minimal info
  2. Link it to an order/order line
  3. Send the order
  4. Go to "reception", see error
@PascalRepond PascalRepond added the bug Breaks something but is not blocking label Aug 8, 2024
@PascalRepond PascalRepond added UX User experience, ergonomy client request Issue reported by production libraries labels Aug 8, 2024
@rerowep rerowep self-assigned this Nov 19, 2024
@PascalRepond PascalRepond mentioned this issue Nov 20, 2024
Merged
rerowep added a commit to rero/rero-ils-ui that referenced this issue Nov 20, 2024
@rerowep
various: fix some display problems
286a423 
* Fixes aqcquisition receipt without identifier.
* Closes: rero/rero-ils#3732
* Displays authorized access point for places and topics.
* Closes: rero/rero-ils#3770
* Fixes RERO data without idendifiedBy.
* Closes: rero/rero-ils#3763

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@rerowep rerowep moved this from Approved to Ready to test in RERO ILS issues Nov 20, 2024
PascalRepond pushed a commit to rero/rero-ils-ui that referenced this issue Dec 3, 2024
@rerowep @PascalRepond
various: fix some display problems
74d3485 
* Fixes aqcquisition receipt without identifier.
* Closes: rero/rero-ils#3732
* Displays authorized access point for places and topics.
* Closes: rero/rero-ils#3770
* Fixes RERO data without idendifiedBy.
* Closes: rero/rero-ils#3763

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rero/rero-ils-ui that referenced this issue Dec 3, 2024
@rerowep
various: fix some display problems
1c68488 
* Fixes aqcquisition receipt without identifier.
* Closes: rero/rero-ils#3732
* Displays authorized access point for places and topics.
* Closes: rero/rero-ils#3770
* Fixes RERO data without idendifiedBy.
* Closes: rero/rero-ils#3763

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rero/rero-ils-ui that referenced this issue Dec 3, 2024
@rerowep
various: fix some display problems
10ffa43 
* Fixes aqcquisition receipt without identifier.
* Closes: rero/rero-ils#3732
* Displays authorized access point for places and topics.
* Closes: rero/rero-ils#3770
* Fixes RERO data without idendifiedBy.
* Closes: rero/rero-ils#3763

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rero/rero-ils-ui that referenced this issue Dec 3, 2024
@rerowep
various: fix some display problems
86ea7f4 
* Fixes aqcquisition receipt without identifier.
* Closes: rero/rero-ils#3732
* Displays authorized access point for places and topics.
* Closes: rero/rero-ils#3770
* Fixes RERO data without idendifiedBy.
* Closes: rero/rero-ils#3763

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@github-project-automation github-project-automation bot moved this from Ready to test to Done in RERO ILS issues Dec 3, 2024
rerowep added a commit to rero/rero-ils-ui that referenced this issue Dec 3, 2024
@rerowep
various: fix some display problems
836f87a 
* Fixes aqcquisition receipt without identifier.
* Closes: rero/rero-ils#3732
* Displays authorized access point for places and topics.
* Closes: rero/rero-ils#3770
* Fixes RERO data without idendifiedBy.
* Closes: rero/rero-ils#3763

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rerowep rerowep

Labels
bug Breaks something but is not blocking client request Issue reported by production libraries UX User experience, ergonomy
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

various: fix some display problems rero/rero-ils-ui
2 participants
@rerowep @PascalRepond