Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persons aren't filtered by views #550

Closed
iGormilhit opened this issue Oct 8, 2019 · 2 comments
Closed

Persons aren't filtered by views #550

iGormilhit opened this issue Oct 8, 2019 · 2 comments
Assignees
@AoNoOokami
Labels
f: consortial Related to the consortial structure or functionalities f: professional ui Professional interface f: search

Comments

@iGormilhit
Copy link

Describe the issue
Every view give access to the complete persons list, even if there's no document/holdings/item associated to theses persons in a given view.

To Reproduce
Steps to reproduce the behavior:

  1. Launch an instance at least containing 11b5271
  2. On the frontpage, click on the "Réseau des bibliothèques du Canton"
  3. Make an empty request to display the entire view results.
  4. See the Persons tabs, with no document/holdings/item associated.

Expected behavior
No person without document/holdings/item should be displayed.
@iGormilhit iGormilhit added f: consortial Related to the consortial structure or functionalities f: search labels Oct 8, 2019
@iGormilhit iGormilhit added this to the issue fixing sprint 24 milestone Oct 29, 2019
@iGormilhit
Copy link
Author

Public search is filtered by views.

Professional search is filtered by logged in professional.

@iGormilhit iGormilhit added the f: professional ui Professional interface label Oct 29, 2019
@iGormilhit iGormilhit removed this from the issue fixing sprint 24 milestone Oct 30, 2019
@pronguen
Copy link
Contributor

pronguen commented Nov 5, 2019

For this issue, the correction must be done only in the public view.
For admin view, see US 984

@AoNoOokami AoNoOokami self-assigned this Dec 17, 2019
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Dec 18, 2019
person: filter by view
94aee95 
* Allows filtering persons by view (organisation)
* Closes rero#550

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Dec 18, 2019
person: filter by view
3f4a6d8 
* Allows filtering persons by view (organisation)
* Closes rero#550

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami mentioned this issue Dec 18, 2019
Merged
6 tasks
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Dec 18, 2019
person: filter by organisation
0960894 
* Allows person filtering by organisation in admin app.
* Closes rero/rero-ils#550.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 6, 2020
person: filter by view
fc3bf6a 
* Allows filtering persons by view (organisation)
* Closes rero#550

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 6, 2020
person: filter by view
7a59462 
* Allows filtering persons by view (organisation)
* Closes rero#550

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 6, 2020
person: filter by view
214a7e2 
* Allows filtering persons by view (organisation)
* Closes rero#550

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 7, 2020
person: filter by view
a215e30 
* Allows filtering persons by view (organisation)
* Closes rero#550

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 7, 2020
person: filter by view
edd57de 
* Allows filtering persons by view (organisation)
* Closes rero#550

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 7, 2020
person: filter by view
0ad0f60 
* Allows filtering persons by view (organisation)
* Closes rero#550

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@jma jma closed this as completed in 7110a77 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AoNoOokami AoNoOokami

Labels
f: consortial Related to the consortial structure or functionalities f: professional ui Professional interface f: search
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iGormilhit @pronguen @AoNoOokami