Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document editor: if all authors are removed from the form, then it's not possible to add an author #609

Closed
iGormilhit opened this issue Nov 7, 2019 · 0 comments
Assignees
Labels
bug (critical) Blocking issue, should be fixed ASAP f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface

Comments

@iGormilhit
Copy link

Describe the issue
If a librarian removes all author fields in the document editor, then he/her has no way to add an author.

To Reproduce
Steps to reproduce the behavior:

  1. Log in as a librarian.
  2. Create or edit a document.
  3. Remove all author fields.
  4. Try to add an author.

Expected behavior
As all author field are removed, the author field should be available in the list of available field on top of the editor. It does work like this for other field, such as identifiedBy.

Software version
ils.test.rero.ch, v0.5.1

ilsdev.test.rero.ch, 9aa529c

Screenshots
rero-ils-editor-no-author

@iGormilhit iGormilhit added bug f: editor Concerns editor based on JSON schema AND custom editor bug (critical) Blocking issue, should be fixed ASAP f: professional ui Professional interface labels Nov 7, 2019
benerken added a commit to benerken/rero-ils that referenced this issue Nov 8, 2019
…he form

* Fixes issue in document editor: when you removed all authors, you were unable to add a new one.
* Modify the jsonschemas (update minItems from 0 to 1).
* Closes: rero#609

Co-Authored-by: Benoit Erken erken.benoit@gmail.com
benerken added a commit to benerken/rero-ils that referenced this issue Nov 8, 2019
* Fixes issue in document editor: when you removed all authors, you were unable to add a new one.
* Modify the jsonschemas (update "minItems" attribute from 0 to 1)
* Closes: rero#609

Co-Authored-by: Benoit Erken <erken.benoit@gmail.com>
Co-Authored-by: Laurent Dubois <laurent.dubois@itld-solutions.be>
@benerken benerken self-assigned this Nov 8, 2019
lauren-d added a commit to lauren-d/rero-ils that referenced this issue Nov 11, 2019
* Fixes issue in document editor: when you removed all authors, you were unable to add a new one.
* Modify the jsonschemas (update "minItems" attribute from 0 to 1)
* Closes: rero#609

Co-Authored-by: Benoit Erken <erken.benoit@gmail.com>
Co-Authored-by: Laurent Dubois <laurent.dubois@itld-solutions.be>
iGormilhit pushed a commit that referenced this issue Nov 11, 2019
* Fixes issue in document editor: when you removed all authors, you were unable to add a new one.
* Modify the jsonschemas (update "minItems" attribute from 0 to 1)
* Closes: #609

Co-Authored-by: Benoit Erken <erken.benoit@gmail.com>
Co-Authored-by: Laurent Dubois <laurent.dubois@itld-solutions.be>
@jma jma closed this as completed in cf47ab2 Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug (critical) Blocking issue, should be fixed ASAP f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface
Projects
None yet
Development

No branches or pull requests

2 participants