Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pickup name of location must be required #794

Closed
pronguen opened this issue Feb 24, 2020 · 1 comment
Closed

Pickup name of location must be required #794

pronguen opened this issue Feb 24, 2020 · 1 comment
Assignees
@zannkukai
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data

Comments

@pronguen
Copy link
Contributor

Describe the issue
The pickup name is missing for pickup locations in pilot libraries.

To Reproduce

  1. Edit this location as a librarian of RBNJ
  2. Try to save

Expected behavior
Pickup name in JSON schema must be corrected to be required, so that we get an error if fixture data is not complete.

Software version
ilspilot
rero-ils version 647a7f3
rero-ils-ui version 30e8cdd1
@BadrAly
Copy link

BadrAly commented Feb 24, 2020

In https://ils.rero.ch/schema/locations/location-v0.0.1.json :

if is_pickup == True then the field pickup_name is mandatory

@iGormilhit iGormilhit added the f: data About data model, importation, transformation, exportation of data, specific for bibliographic data label Feb 24, 2020
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Mar 11, 2020
@zannkukai
location: adapt JSON schema for pickup_name required if is_pickup
0f2f79a 
Before this change, the location JSON schema accept that the location was a
pickup location (is_pickup=true) but without pickup_name. This fix change this
behavior ; when a location is defined as pickup location, then the 'pickup_name'
is now required.

Note : the schema already contains behavior for the formly editor

* Closes rero#794.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Mar 11, 2020
Merged
7 tasks
@zannkukai zannkukai self-assigned this Mar 11, 2020
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Mar 13, 2020
@zannkukai
location: adapt JSON schema for pickup_name required if is_pickup
6552d3b 
Before this change, the location JSON schema accept that the location was a
pickup location (is_pickup=true) but without pickup_name. This fix change this
behavior ; when a location is defined as pickup location, then the 'pickup_name'
is now required.

Note : the schema already contains behavior for the formly editor

* Closes rero#794.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Mar 13, 2020
@zannkukai
location: adapt JSON schema for pickup_name required if is_pickup
1c11f0a 
Before this change, the location JSON schema accept that the location was a
pickup location (is_pickup=true) but without pickup_name. This fix change this
behavior ; when a location is defined as pickup location, then the 'pickup_name'
is now required.

Note : the schema already contains behavior for the formly editor

* Closes rero#794.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Mar 13, 2020
@zannkukai
location: adapt JSON schema for pickup_name required if is_pickup
6e9de30 
Before this change, the location JSON schema accept that the location was a
pickup location (is_pickup=true) but without pickup_name. This fix change this
behavior ; when a location is defined as pickup location, then the 'pickup_name'
is now required.

Note : the schema already contains behavior for the formly editor

* Closes rero#794.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Mar 18, 2020
@zannkukai
location: adapt JSON schema for pickup_name required if is_pickup
8826c65 
Before this change, the location JSON schema accept that the location was a
pickup location (is_pickup=true) but without pickup_name. This fix change this
behavior ; when a location is defined as pickup location, then the 'pickup_name'
is now required.

Note : the schema already contains behavior for the formly editor

* Closes rero#794.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Mar 18, 2020
@zannkukai
location: adapt JSON schema for pickup_name required if is_pickup
27d65bf 
Before this change, the location JSON schema accept that the location was a
pickup location (is_pickup=true) but without pickup_name. This fix change this
behavior ; when a location is defined as pickup location, then the 'pickup_name'
is now required.

Note : the schema already contains behavior for the formly editor

* Closes rero#794.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Mar 18, 2020
@zannkukai
location: adapt JSON schema for pickup_name required if is_pickup
e69162b 
Before this change, the location JSON schema accept that the location was a
pickup location (is_pickup=true) but without pickup_name. This fix change this
behavior ; when a location is defined as pickup location, then the 'pickup_name'
is now required.

Note : the schema already contains behavior for the formly editor

* Closes rero#794.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iGormilhit @pronguen @zannkukai @BadrAly