Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renewal badge irrelevant for checked in items #797

Closed
pronguen opened this issue Feb 25, 2020 · 0 comments · Fixed by rero/rero-ils-ui#335
Closed

Renewal badge irrelevant for checked in items #797

pronguen opened this issue Feb 25, 2020 · 0 comments · Fixed by rero/rero-ils-ui#335
Assignees
@zannkukai
Labels
f: circulation Concerns the circulation interface or backend f: professional ui Professional interface

Comments

@pronguen
Copy link
Contributor

Describe the issue
When I do a checkin of an item that had been renewed before, the renewal badge is displayed. This is the case in the checkin and in the checkout form.

To Reproduce

  1. Loan an item for a patron
  2. Renew it
  3. Do a checkin in the checkout form or in the checkin form
  4. See the badge

Expected behavior
As it is a checkin, renewal info is not relevant. For all checkin (in checkin and checkout forms), the renewal badge is never displayed.

Software version
ilsdev
rero-ils version e2fbc6b
rero-ils-ui version 925ffabb
@pronguen pronguen added the f: circulation Concerns the circulation interface or backend label Feb 25, 2020
@iGormilhit iGormilhit added the f: professional ui Professional interface label Feb 26, 2020
@iGormilhit iGormilhit changed the title Renewal badge at checkin Renewal badge irrelevant for checked in items Apr 21, 2020
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Aug 13, 2020
@zannkukai
item: conditional renewal badges.
b2f1c1d 
The renewal badges should not be displayed when a checkin action in done
on the corresponding item. This commit change the behavior of this badge
to be conditional depending if a 'checkin' action is done on the item.

Closes rero/rero-ils#797

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Aug 13, 2020
Merged
7 tasks
@zannkukai zannkukai self-assigned this Aug 13, 2020
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Aug 14, 2020
@zannkukai
item: conditional renewal badges.
1452669 
The renewal badges should not be displayed when a checkin action in done
on the corresponding item. This commit change the behavior of this badge
to be conditional depending if a 'checkin' action is done on the item.

Closes rero/rero-ils#797

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Aug 17, 2020
@zannkukai
item: conditional renewal badges.
94789e1 
The renewal badges should not be displayed when a checkin action in done
on the corresponding item. This commit change the behavior of this badge
to be conditional depending if a 'checkin' action is done on the item.

Closes rero/rero-ils#797

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to rero/rero-ils-ui that referenced this issue Aug 17, 2020
@zannkukai
item: conditional renewal badges.
3654064 
The renewal badges should not be displayed when a checkin action in done
on the corresponding item. This commit change the behavior of this badge
to be conditional depending if a 'checkin' action is done on the item.

Closes rero/rero-ils#797

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to rero/rero-ils-ui that referenced this issue Aug 19, 2020
@zannkukai
item: conditional renewal badges.
5361678 
The renewal badges should not be displayed when a checkin action in done
on the corresponding item. This commit change the behavior of this badge
to be conditional depending if a 'checkin' action is done on the item.

Closes rero/rero-ils#797

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
f: circulation Concerns the circulation interface or backend f: professional ui Professional interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

item: conditional renewal badges. zannkukai/rero-ils-ui
3 participants
@iGormilhit @pronguen @zannkukai