Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement needed on the request information when doing a checkin #883

Closed
pronguen opened this issue Apr 1, 2020 · 0 comments · Fixed by rero/rero-ils-ui#304
Closed

Improvement needed on the request information when doing a checkin #883

pronguen opened this issue Apr 1, 2020 · 0 comments · Fixed by rero/rero-ils-ui#304
Assignees
@zannkukai
Labels
f: circulation Concerns the circulation interface or backend
Milestone
v0.11.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Apr 1, 2020

Describe the issue
Doing a checkin of an item with a request, in the checkin form OR in the checkout form:

  • the icon of the request is not clear (exclamation mark)
  • the number of requests is not useful since it is a checkin
  • the name of the patron of the request is useful, but only displayed in the expanded line

To Reproduce

  1. Do a checkin of an item with a request
    • once in the checkin form
    • once in the checkout form

Expected behavior

  • the requests should be displayed with the same icon as for "Create a request for a patron" (it is a small shopping basket).
  • the number of requests is not displayed
  • the name of the patron of the request (next current loan) is diplayed after the icon (might be abridged if too long)

This does NOT apply when doing a checkout!

Software version
ilsdev (rero-ils version 0524143, rero-ils-ui version 2a6a4f48)
ilspilot (phase 1 of tests)

Screenshots
Now
image

Wanted
image
(note: see #826 to display the name correctly)
@pronguen pronguen added the f: circulation Concerns the circulation interface or backend label Apr 1, 2020
@iGormilhit iGormilhit changed the title Request display when doing a checkin Improvement needed on the request information when doing a checkin Apr 21, 2020
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jul 3, 2020
@zannkukai
ui: better request badge into circulation module
0aca7dc 
Updates the badge used to notify that an item is requested by another
patron : change exclamation icon to shopping-bag icon and display the
patron name.

* Closes rero/rero-ils#883

Co-Authored-By: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai self-assigned this Jul 3, 2020
@zannkukai zannkukai mentioned this issue Jul 3, 2020
Merged
7 tasks
@iGormilhit iGormilhit added this to the v0.11.0 milestone Jul 6, 2020
iGormilhit pushed a commit to zannkukai/rero-ils-ui that referenced this issue Jul 7, 2020
@zannkukai
ui: improve request badge into circulation module
ea2d652 
Updates the badge used to notify that an item is requested by another
patron: change exclamation icon to shopping-bag icon and display the
patron name.

* Closes rero/rero-ils#883.

Co-Authored-By: Renaud Michotte <renaud.michotte@gmail.com>
iGormilhit pushed a commit to rero/rero-ils-ui that referenced this issue Jul 9, 2020
@zannkukai
ui: improve request badge into circulation module
d1d808f 
Updates the badge used to notify that an item is requested by another
patron: change exclamation icon to shopping-bag icon and display the
patron name.

* Closes rero/rero-ils#883.

Co-Authored-By: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
f: circulation Concerns the circulation interface or backend
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging a pull request may close this issue.

ui: better request badge into circulation module zannkukai/rero-ils-ui
3 participants
@iGormilhit @pronguen @zannkukai