Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identifier type not translated in document detailed view #918

Closed
pronguen opened this issue Apr 9, 2020 · 3 comments · Fixed by #1416
Closed

Identifier type not translated in document detailed view #918

pronguen opened this issue Apr 9, 2020 · 3 comments · Fixed by #1416
Assignees
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data translations Translations
Milestone

Comments

@pronguen
Copy link
Contributor

pronguen commented Apr 9, 2020

Describe the issue
The identifier type ist not translated in document detailed view. It is the case in the public and in the professional interface. In the editor it is translated.

To Reproduce

  1. Open the detailed view of a document with an Audio issue number

Expected behavior
Identifier type is translated.

Software version
ils.test.rero.ch (v0.6.1)
ilspilot (test phase 1)

Screenshots
image

@pronguen pronguen added the translations Translations label Apr 9, 2020
@zannkukai
Copy link
Contributor

The problem here is that the value stored into invenio is "bf:audioissuenumber", "bf:isbn", ...
We remove the "bf:" to display the badge but the string "audioissuenumber" isn't present into traductions ("audio issue number" is present).

To solve this, maybe it will be necessary to include all select values into translation files (enum values from JSON schemas - No more need to use "forms/options" ... but it will result of potential multiple same traduction for different values ["bf:audioissuenumber" and "audio issue number" should be translated]).
Or more simply (but more dirty way), add some manual_translation....

@iGormilhit iGormilhit added f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface labels Jul 6, 2020
@iGormilhit
Copy link

@zannkukai Why do we have to change the strings from bf:audioissuenumber to audioissuenumber, as long as we translate them ?

@iGormilhit
Copy link

This is a field that we have to change as specified in the JSON schema guidelines, ie setting the label with the value value, in order to translate it only once (as it is already the case in SONAR).

@iGormilhit iGormilhit self-assigned this Sep 16, 2020
@iGormilhit iGormilhit added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data and removed f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface labels Sep 16, 2020
@AoNoOokami AoNoOokami self-assigned this Nov 9, 2020
@AoNoOokami AoNoOokami added this to the v0.14.0 milestone Nov 9, 2020
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 9, 2020
* Displays qualifier, status and note for identifiers.
* Adds identifier types to translated strings.
* Closes rero#1403.
* Closes rero#918.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 9, 2020
* Displays qualifier, status and note for identifiers.
* Adds identifier types to translated strings.
* Closes rero#1403.
* Closes rero#918.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 10, 2020
* Displays qualifier, status and note for identifiers.
* Adds identifier types to translated strings.
* Closes rero#1403.
* Closes rero#918.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 10, 2020
* Displays qualifier, status and note for identifiers.
* Adds identifier types to translated strings.
* Closes rero#1403.
* Closes rero#918.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit that referenced this issue Nov 10, 2020
* Displays qualifier, status and note for identifiers.
* Adds identifier types to translated strings.
* Closes #1403.
* Closes #918.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data translations Translations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants