Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions for item/patron types and circ policies #932

Closed
pronguen opened this issue Apr 15, 2020 · 0 comments
Closed

Permissions for item/patron types and circ policies #932

pronguen opened this issue Apr 15, 2020 · 0 comments
Labels
f: permissions Concerns the rights management

Comments

@pronguen
Copy link
Contributor

pronguen commented Apr 15, 2020

Describe the issue
A librarian is able to edit (and remove?) item types, patron types and circulation policies.

To Reproduce

  1. Log in a as a librarian
  2. Edit an item type
  3. Save

Expected behavior
A librarian should not be able to edit/remove item types, patron types and circulation policies.

Software version
ils.test.rero.ch (v0.7.0)
ilspilot (test, phase 1)

@pronguen pronguen added the f: permissions Concerns the rights management label Apr 15, 2020
@pronguen pronguen changed the title Permissions for item/patron types Permissions for item/patron types and circ policies Apr 15, 2020
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue May 14, 2020
Updates way how permissions are used. Instead to use permissions
returned by a search query, use permissions provided by the backend
permission API (`/api/permissions/<type>/<pid>`).
After these changes, we could refactor the backend SearchSerializer to
remove permissions and speed up search query results.

This commit also updates button and functionalities according to the UX
chart.

* Closes rero/rero-ils#819
* Closes rero/rero-ils#932

Co-authored-by : Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue May 14, 2020
Updates way how permissions are used. Instead to use permissions
returned by a search query, use permissions provided by the backend
permission API (`/api/permissions/<type>/<pid>`).
After these changes, we could refactor the backend SearchSerializer to
remove permissions and speed up search query results.

This commit also updates button and functionalities according to the UX
chart.

* Closes rero/rero-ils#819
* Closes rero/rero-ils#932

Co-authored-by : Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue May 19, 2020
Updates way how permissions are used. Instead to use permissions
returned by a search query, use permissions provided by the backend
permission API (`/api/permissions/<type>/<pid>`).
After these changes, we could refactor the backend SearchSerializer to
remove permissions and speed up search query results.

This commit also updates button and functionalities according to the UX
chart.

* Closes rero/rero-ils#819
* Closes rero/rero-ils#932

Co-authored-by : Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue May 19, 2020
Updates way how permissions are used. Instead to use permissions
returned by a search query, use permissions provided by the backend
permission API (`/api/permissions/<type>/<pid>`).
After these changes, we could refactor the backend SearchSerializer to
remove permissions and speed up search query results.

This commit also updates button and functionalities according to the UX
chart.

* Closes rero/rero-ils#819
* Closes rero/rero-ils#932

Co-authored-by : Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue May 20, 2020
Updates way how permissions are used. Instead to use permissions
returned by a search query, use permissions provided by the backend
permission API (`/api/permissions/<type>/<pid>`).
After these changes, we could refactor the backend SearchSerializer to
remove permissions and speed up search query results.

This commit also updates button and functionalities according to the UX
chart.

* Closes rero/rero-ils#819
* Closes rero/rero-ils#932

Co-authored-by : Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue May 27, 2020
Updates way how permissions are used. Instead to use permissions
returned by a search query, use permissions provided by the backend
permission API (`/api/permissions/<type>/<pid>`).
After these changes, we could refactor the backend SearchSerializer to
remove permissions and speed up search query results.

This commit also updates button and functionalities according to the UX
chart.

* Closes rero/rero-ils#819
* Closes rero/rero-ils#932

Co-authored-by : Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: permissions Concerns the rights management
Projects
None yet
Development

No branches or pull requests

1 participant