Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oaiharvest port 8443 #100

Merged
merged 1 commit into from
Oct 2, 2018
Merged

oaiharvest port 8443 #100

merged 1 commit into from
Oct 2, 2018

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Oct 1, 2018 

fix: oaiharharvest port 8443
feat: invenio cli utils display of schedules
feat: update of oaiharvest configurations

Signed-off-by: Peter Weber Peter.Weber@rero.ch

@rerowep rerowep requested review from Garfield-fr, jma and BadrAly October 1, 2018 10:23
@iGormilhit
Copy link

Please try to follow commit message formatting recommandations: https://github.com/rero/rero-ils/blob/master/CONTRIBUTING.rst

    -m "component: title without verbs"
    -m "* NEW Adds your new feature."
    -m "* FIX Fixes an existing issue."
    -m "* BETTER Improves and existing feature."
    -m "* Changes something that should not be visible in release notes."

@rerowep rerowep force-pushed the oaiharvest branch 4 times, most recently from e7ecd6b to a13ff05 Compare October 1, 2018 13:59
@rerowep
fix: oaiharvest port 8443
77c65e8 
    * FIX: oaiharharvest port 8443
    * NEW: invenio cli utils display of schedules
    * FIX: update of oaiharvest configurations
    * FIX: click version 7 arguments definitions

Signed-off-by: Peter Weber <Peter.Weber@rero.ch>
iGormilhit
iGormilhit approved these changes Oct 2, 2018
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me. The tests run successfully, I could update the oaihaverster configuration and harvest the ebooks.

@rerowep rerowep merged commit 80245b6 into rero:master Oct 2, 2018
@rerowep rerowep deleted the oaiharvest branch October 2, 2018 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

@jma jma Awaiting requested review from jma

@BadrAly BadrAly Awaiting requested review from BadrAly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rerowep @iGormilhit