test: fix run-test and setup #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadrAly
suggested changes
May 19, 2020
BadrAly
approved these changes
May 19, 2020
rerowep
force-pushed
the
wep-fix-run-tests
branch
from
ee6e9dd to
c310c5a
Compare
|
I got this error on bootstrap: |
rerowep
force-pushed
the
wep-fix-run-tests
branch
3 times, most recently
from
2872d6b to
fd9f5cb
Compare
blankoworld
reviewed
May 19, 2020
scripts/setup
Outdated
Comment on lines
373
to
376
| info_msg "Start OAI harvesting 100" | ||
| eval ${PREFIX} invenio oaiharvester harvest -n ebooks -a max=100 -q | ||
| info_msg "For ebooks harvesting run:" | ||
| msg "\tinvenio oaiharvester harvest -n ebooks -a max=100 -q" | ||
| # info_msg "Start OAI harvesting 100" | ||
| # eval ${PREFIX} invenio oaiharvester harvest -n ebooks -a max=100 -q |
There was a problem hiding this comment.
I suggest:
- do not make ebook harvesting by default
- add a parameter that activate the ebook harvesting. In deployment or not.
rerowep
force-pushed
the
wep-fix-run-tests
branch
from
fd9f5cb to
e043902
Compare
lauren-d
approved these changes
May 19, 2020
* Fixes problem with ui/documents/test_documents_api.py not raising exceptions. closes rero#1000 * Changes setup back to not run the ebooks harvesting for normal setup. * Corrects unused imports in scripts/__init__.py Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep
force-pushed
the
wep-fix-run-tests
branch
from
e043902 to
e8a364c
Compare
blankoworld
approved these changes
May 19, 2020
jma
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exceptions. closes Errors when running run_tests.sh #1000
Co-Authored-by: Peter Weber peter.weber@rero.ch
Why are you opening this PR?
How to test?
Code review check list