translation: fix translations API #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
zan-#fix-translations-api
branch
2 times, most recently
from
ba926b7
to
419e227
Compare
iGormilhit
approved these changes
Jun 2, 2020
jma
approved these changes
Jun 2, 2020
Fixes bug with translations API. If an exception occurred during execution of this API, the exception should be logged into the `current_app` logger. But `current_app` context was never loaded from flask module before. This PR also hacks translation files data : if a string is not translated, rather than return an empty string, the original string will be used. * Adapts unitest to check theses cases. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch> Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-#fix-translations-api
branch
from
419e227
to
e178885
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug with translations API. If an exception occurred during
execution of this API, the exception should be logged into the
current_applogger. Butcurrent_appcontext was never loaded fromflask module before.
This PR also hacks translation files data : if a string is not
translated, rather than return an empty string, the original string will
be used.
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
Code review check list