notifications: patron url #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerowep
force-pushed
the
wep-#1537-fix-patron-link
branch
from
db0ef6b to
bbe3871
Compare
iGormilhit
suggested changes
Jun 8, 2020
There was a problem hiding this comment.
My suggestion for the commit message:
notifications: fix patron URL construction
The patron profile URL in the notification messages should be adapted to the running instance.
* Corrects patron URL. `RERO_ILS_APP_BASE_URL` is used to construct the patron URL. Closes #802.
* Adds command line interface for notifications. Process of notifications can now be started with `invenio run notifications process`.
bbe3871 to
838b707
Compare
rerowep
force-pushed
the
wep-#1537-fix-patron-link
branch
3 times, most recently
from
8943b36 to
b3d9e34
Compare
rerowep
force-pushed
the
wep-#1537-fix-patron-link
branch
from
b3d9e34 to
b27fa78
Compare
iGormilhit
suggested changes
Jun 10, 2020
There was a problem hiding this comment.
Commit message:
notifications: adapt patron url to the instance
The patron URL displayed in the notifications sent to to the patron
should be automatically changed according to the deployed instance.
* Corrects patron URL in notifications. `RERO_ILS_APP_URL` is used to
construct the patron URL. Closes #802
* Adds command line interface for notifications. Process of
notifications can now be started with `invenio run notifications
process`.
* Uses standart JSONSCHEMAS_ENDPOINT = '/schemas'.
* Uses JSONSCHEMAS_REPLACE_REFS = True to resolve $ref before serving a
schema.
* Deletes all unnecessary `$schema` in fixtures.
b27fa78 to
60c49d9
Compare
iGormilhit
approved these changes
Jun 15, 2020
rerowep
force-pushed
the
wep-#1537-fix-patron-link
branch
from
60c49d9 to
01394d6
Compare
jma
approved these changes
Jun 17, 2020
jma
reviewed
Jun 17, 2020
rerowep
force-pushed
the
wep-#1537-fix-patron-link
branch
from
01394d6 to
9de1675
Compare
Should be interesting to test. |
BadrAly
suggested changes
Jun 18, 2020
zannkukai
approved these changes
Jun 18, 2020
rerowep
force-pushed
the
wep-#1537-fix-patron-link
branch
from
9de1675 to
745a296
Compare
zannkukai
approved these changes
Jun 18, 2020
lauren-d
approved these changes
Jun 18, 2020
BadrAly
approved these changes
Jun 18, 2020
The patron URL displayed in the notifications sent to to the patron should be automatically changed according to the deployed instance. * Corrects patron URL in notifications. `RERO_ILS_APP_URL` is used to construct the patron URL. Closes rero#802 * Adds command line interface for notifications. Process of notifications can now be started with `invenio run notifications process`. * Uses standart JSONSCHEMAS_ENDPOINT = '/schemas'. * Uses JSONSCHEMAS_REPLACE_REFS = True to resolve $ref before serving a schema. * Deletes all unnecessary `$schema` in fixtures. * Deletes `document-minimal-v0.0.1.json` schema file. Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep
force-pushed
the
wep-#1537-fix-patron-link
branch
from
745a296 to
31968af
Compare
iGormilhit
approved these changes
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RERO_ILS_APP_URLis used toconstruct the patron url. closes Link to the patron profile not adapted to the concerned instance in the notification message. #802
can now be started with
invenio run notifications process.schema.
$schemain fixtures.Why are you opening this PR?
How to test?
Code review check list