Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json schema: use the select menu with order #1086

Merged
merged 1 commit into from
Jul 21, 2020
Merged

json schema: use the select menu with order #1086

merged 1 commit into from
Jul 21, 2020

Conversation

Garfield-fr
Copy link
Contributor

  • Updates JSON schema form to use the new select menu with order.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Dependencies

My PR depends on the following ng-core's PR(s):

  • rero/ng-core#7400a310fbeda8432ebf944c402325e6bc9878c1

How to test?

  • Add a document (or other ressource) and check select menu order.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@Garfield-fr Garfield-fr marked this pull request as draft July 6, 2020 08:58
@Garfield-fr
json schema: use the select menu with order
32db98d 
* Updates JSON schema form to use the new select menu with order.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@iGormilhit iGormilhit added this to the v0.11.0 milestone Jul 14, 2020
@Garfield-fr Garfield-fr marked this pull request as ready for review July 16, 2020 09:57
iGormilhit
iGormilhit approved these changes Jul 20, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

jma
jma approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do it for all select in the application, why not having this behaviour as default?

@Garfield-fr Garfield-fr merged commit e1f6c42 into rero:dev Jul 21, 2020
@Garfield-fr Garfield-fr deleted the zub-select-order branch September 7, 2020 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@jma jma jma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Garfield-fr @jma @iGormilhit @lauren-d