Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

permission: refactoring document permission factory #1103

Merged
merged 1 commit into from
Jul 28, 2020
Merged

permission: refactoring document permission factory #1103

merged 1 commit into from
Jul 28, 2020

Conversation

zannkukai
Copy link
Contributor

@zannkukai zannkukai commented Jul 20, 2020 •
edited
Loading

This commit create a specific permission class about document resource.
This class centralizes all permissions related to document resources.

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@zannkukai zannkukai self-assigned this Jul 20, 2020
@zannkukai zannkukai force-pushed the zan-permissions-refactoring-documents branch 3 times, most recently from d643d30 to 25e52ed Compare July 21, 2020 07:01
@zannkukai zannkukai marked this pull request as ready for review July 21, 2020 07:07
blankoworld
blankoworld suggested changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@blankoworld blankoworld left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In rero_ils/config.py, you cannot import librarian_update_permission_factory as this methid was deleted.

@zannkukai zannkukai force-pushed the zan-permissions-refactoring-documents branch 2 times, most recently from 1164093 to f6be38e Compare July 22, 2020 08:53
@zannkukai zannkukai requested review from blankoworld and removed request for lauren-d July 22, 2020 09:22
@zannkukai zannkukai force-pushed the zan-permissions-refactoring-documents branch from f6be38e to 0405eea Compare July 22, 2020 11:22
@zannkukai zannkukai added the f: permissions Concerns the rights management label Jul 23, 2020
@zannkukai
permission: refactoring document permission factory
22fa9c8 
This commit create a specific permission class about document resource.
This class centralizes all permissions related to document resources.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai force-pushed the zan-permissions-refactoring-documents branch from 0405eea to 22fa9c8 Compare July 23, 2020 12:33
@zannkukai zannkukai merged commit 6c91e81 into rero:dev Jul 28, 2020
@zannkukai zannkukai deleted the zan-permissions-refactoring-documents branch July 28, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BadrAly BadrAly BadrAly approved these changes

@benerken benerken benerken approved these changes

@blankoworld blankoworld blankoworld approved these changes

Assignees

@zannkukai zannkukai

Labels
f: permissions Concerns the rights management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zannkukai @blankoworld @benerken @BadrAly