patron: add circulation statistic API #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
zan-patron-circulation-stat
branch
2 times, most recently
from
3382e7f to
cb632de
Compare
lauren-d
requested changes
Oct 19, 2020
zannkukai
force-pushed
the
zan-patron-circulation-stat
branch
2 times, most recently
from
d493943 to
afbc9dc
Compare
lauren-d
approved these changes
Oct 20, 2020
benerken
approved these changes
Oct 20, 2020
AoNoOokami
approved these changes
Oct 20, 2020
BadrAly
suggested changes
Oct 26, 2020
|
|
||
| login_user_via_session(client, librarian_martigny_no_email.user) | ||
| res = client.get(url) | ||
| assert res.status_code == 200 |
There was a problem hiding this comment.
Can you add a test to validate the output of the function get_loans_stats_by_patron_pid? so we are sure it is returning the expected results
There was a problem hiding this comment.
It's difficult because stats are different if you execute the test as standalone or with the full tests.
BadrAly
approved these changes
Oct 26, 2020
zannkukai
force-pushed
the
zan-patron-circulation-stat
branch
from
afbc9dc to
9c134a2
Compare
BadrAly
approved these changes
Oct 27, 2020
zannkukai
force-pushed
the
US1643-borrow-limits
branch
from
da250ee to
97dfe0e
Compare
zannkukai
force-pushed
the
zan-patron-circulation-stat
branch
3 times, most recently
from
b97aa84 to
00cacf1
Compare
zannkukai
force-pushed
the
zan-patron-circulation-stat
branch
3 times, most recently
from
cb2b3d5 to
adf2b28
Compare
Adds an API to get patron circulation informations. This API return the number of loans relate to this patron by state and messages useful for the circulation about this patron (patron blocked, checkout limit, ...) Closes rero#1278 Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-patron-circulation-stat
branch
from
adf2b28 to
befae76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an API to get patron circulation loan statistics. This API return
the number of loans relate to this patron by state.
Closes #1278
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
Code review check list