Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maj circulation ui #724 #153

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Maj circulation ui #724 #153

merged 1 commit into from
Dec 11, 2018

Conversation

jma
Copy link
Contributor

@jma jma commented Dec 10, 2018

Automatic action from item barcode is not working.

To test:

  • rebase, bootstrap and setup as usual
  • go to the admin interface
  • tests should work at instance level
  • tests does not work as angular project level
  • to test the dev server of angular got to ui/admin directory and run npm i and ng serve --configuration proxy
  • note that this interface is not fully working, basically it is not possible to scan an item_barcode

@jma jma force-pushed the maj-circulation-ui-#724 branch from 1829e6e to c21f0b8 Compare December 10, 2018 12:40
@BadrAly BadrAly self-requested a review December 10, 2018 15:12
Copy link

@BadrAly BadrAly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested available circ functionalities , no code review.

Copy link
Contributor

@rerowep rerowep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proxy with http or https ???

@jma jma force-pushed the maj-circulation-ui-#724 branch from c21f0b8 to a697579 Compare December 11, 2018 09:39
* suppress reroils-circulation-ui dependencies
* checkin with a given patron barcode
* requests validation
* add modal dialog for changes confirmation
* alert messages mecanism
* translations
* shared component mecanism
* root level services

Signed-off-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma force-pushed the maj-circulation-ui-#724 branch from a697579 to 136592c Compare December 11, 2018 09:41
@jma jma requested a review from iGormilhit December 11, 2018 10:26
@jma jma merged commit 454252d into rero:master Dec 11, 2018
@jma jma deleted the maj-circulation-ui-#724 branch December 12, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants