Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documents: group holdings by libraries #1541

Merged
merged 1 commit into from
Dec 15, 2020
Merged

documents: group holdings by libraries #1541

merged 1 commit into from
Dec 15, 2020

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Dec 3, 2020 •
edited
Loading

The layout of the book type no longer shows the holdings structure.
The buttons have been aligned vertically below the data.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

How to test?

  • Check book layout and serial layout.
  • Check order (sort by library pid and location pid)

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@Garfield-fr Garfield-fr force-pushed the zub-holding-grouped-1399 branch 2 times, most recently from f343264 to 22bcf7e Compare December 3, 2020 13:16
iGormilhit
iGormilhit suggested changes Dec 3, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message proposition:

documents: group holdings by libraries

The layout of the book type no longer shows the holdings structure.
The buttons have been aligned vertically below the data.

* Closes #1399.

rero_ils/modules/documents/templates/rero_ils/_anonymous_button.html Outdated Show resolved Hide resolved
rero_ils/modules/documents/templates/rero_ils/_request_button.html Outdated Show resolved Hide resolved
rero_ils/modules/documents/templates/rero_ils/_request_button.html Outdated Show resolved Hide resolved
@iGormilhit iGormilhit added enhancement Improvement of an existing feature f: public ui Public interface, as opposed to the professional interface labels Dec 3, 2020
@iGormilhit iGormilhit added this to the v1.0.0 milestone Dec 3, 2020
@iGormilhit iGormilhit changed the title document: holdings should be grouped by libraries documents: group holdings by libraries Dec 3, 2020
@Garfield-fr Garfield-fr force-pushed the zub-holding-grouped-1399 branch 3 times, most recently from f6ac0a6 to 8d708a7 Compare December 10, 2020 05:57
@Garfield-fr Garfield-fr force-pushed the zub-holding-grouped-1399 branch 2 times, most recently from 6cb2d6e to eb87cbd Compare December 11, 2020 09:17
@Garfield-fr Garfield-fr force-pushed the zub-holding-grouped-1399 branch 3 times, most recently from a25f6c1 to bff91ee Compare December 14, 2020 06:10
@Garfield-fr Garfield-fr force-pushed the zub-holding-grouped-1399 branch from bff91ee to 4ba63b7 Compare December 14, 2020 07:17
@AoNoOokami AoNoOokami removed their request for review December 14, 2020 10:11
@Garfield-fr Garfield-fr force-pushed the zub-holding-grouped-1399 branch from 4ba63b7 to 540c3c0 Compare December 14, 2020 10:48
@Garfield-fr Garfield-fr force-pushed the zub-holding-grouped-1399 branch 2 times, most recently from 7a47e4e to 8ef9251 Compare December 14, 2020 10:53
@pronguen
Copy link
Contributor

pronguen commented Dec 14, 2020 •
edited by mmo
Loading

  • We wanted the holdings of the librarian login library to be displayed first (pro interface): this is not the case.
  • We wanted the holdings of the patron affiliation library to be displayed first (public interface): this is not the case.
  • Call numbers are not displayed on public interface. (They seem now to be displayed, but not correctly.)
  • Items could be grouped by libraries; it will give a better overview for the patron [see image below, nice to have]
    image
  • The display of the holdings detailed view is not good anymore (see image below). This is maybe not linked to this PR.
    image
  • I receive an internal error server on this public detailed view: https://ilsdev.test.rero.ch/global/documents/1077. I wanted to check if the enumerationAndChronology was displayed... It seems you have been deploying a new version during our tests.

@Garfield-fr
documents: group holdings by libraries
846aa11 
The layout of the book type no longer shows the holdings structure.
The buttons have been aligned vertically below the data.

* Fixes parent $ref title on local fields schema.
* Fixes enumeration and chronology on document detail view.
* Closes rero#1399.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr force-pushed the zub-holding-grouped-1399 branch from 8ef9251 to 846aa11 Compare December 14, 2020 13:46
@Garfield-fr Garfield-fr marked this pull request as draft December 14, 2020 15:02
@Garfield-fr Garfield-fr marked this pull request as ready for review December 15, 2020 09:24
@Garfield-fr Garfield-fr merged commit 6492e80 into rero:dev Dec 15, 2020
@Garfield-fr Garfield-fr deleted the zub-holding-grouped-1399 branch December 15, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@BadrAly BadrAly BadrAly approved these changes

@benerken benerken benerken approved these changes

@zannkukai zannkukai zannkukai approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

Assignees
No one assigned
Labels
enhancement Improvement of an existing feature f: public ui Public interface, as opposed to the professional interface
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Holdings should be grouped by libraries
7 participants
@Garfield-fr @pronguen @iGormilhit @zannkukai @benerken @BadrAly @lauren-d