Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout: item detailed view #172

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Layout: item detailed view #172

merged 1 commit into from
Jan 17, 2019

Conversation

iGormilhit
Copy link

⚠️ Not to be merged into master, but into refactoring-layout branch (as mentioned above)

  • BETTER: split scss for detailed view and page
  • BETTER: remove custom margin and padding by bootstrap classes
  • BETTER: adapt item detailed view to new page template
  • NEW: display document type icon
  • FIX: add padding to the main footer

Signed-off-by: Igor Milhit igor.milhit@rero.ch

To test

  • log in as a librarian
  • display an item detailed view
  • try item with transaction (in transit, borrowed, requested)
  • try with large, medium, small screens

rerowep
rerowep requested changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@rerowep rerowep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont't like warnings:
'''npm WARN bootstrap@4.1.3 requires a peer of popper.js@^1.14.3 but none is installed. You must install peer dependencies yourself.'''

The location link is not working!

@iGormilhit
Copy link
Author

@rerowep

  1. popper.js is include in the bundle now, should complain no more.
  2. Location link is fixed.

@NicolasLabat
Copy link
Contributor

Active transactions on an item are displayed on the item detailed view in a section of the page under the title "Transactions". If there are no transactions, this title doesn't appear.
But for items with status "missing", "Transactions" appears and is empty. It seems to make no sense.
Example : 10000000016

@iGormilhit
Copy link
Author

@NicolasLabat You're right, I have to fix this. Thanks.

Layout: item detailed view
c87bb37 
* BETTER: split scss for detailed view and page
* BETTER: remove custom margin and padding by bootstrap classes
* BETTER: adapt item detailed view to new page template
* NEW: display document type icon
* FIX: add padding to  the main footer
* FIX: closes #43
* BETTER: clean main rero ils js bundle

Signed-off-by: Igor Milhit <igor.milhit@rero.ch>
@iGormilhit
Copy link
Author

@NicolasLabat Fixed, the transaction section appears only if the item is on loan, in transit or is requested.

@iGormilhit iGormilhit merged commit 165cd28 into rero:refactoring-layout Jan 17, 2019
@iGormilhit iGormilhit deleted the layout-item-detailed-view branch January 23, 2019 09:26
@iGormilhit iGormilhit mentioned this pull request Jan 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rerowep rerowep rerowep approved these changes

@jma jma Awaiting requested review from jma

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iGormilhit @NicolasLabat @rerowep