Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout: person detailed view #176

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Layout: person detailed view #176

merged 1 commit into from
Jan 23, 2019

Conversation

iGormilhit
Copy link

  • BETTER: implement new layout to person detailed views
  • BETTER: move person macro to person module

Signed-off-by: Igor Milhit igor.milhit@rero.ch


To test

  • invenio collect -v
  • display http://localhost:5000/persons/77 (use the tab navigation)
  • try with different screens size

Copy link

@BadrAly BadrAly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. If possible fix the : as shown in the attachement.

screen shot 2019-01-22 at 3 29 09 pm

* BETTER: implement new layout to person detailed views
* BETTER: move person macro to person module
* NEW: add an HTML class for external link
* FIX: stop using CSS after properties to add ':'

Signed-off-by: Igor Milhit <igor.milhit@rero.ch>
@iGormilhit
Copy link
Author

@BadrAly I've pushed a new version of my commit, fixing this, using a more traditional method to add :.

@BadrAly
Copy link

BadrAly commented Jan 23, 2019

@BadrAly I've pushed a new version of my commit, fixing this, using a more traditional method to add :.

Yes, problem is fixed.

@iGormilhit iGormilhit merged commit a57c6cb into rero:refactoring-layout Jan 23, 2019
@iGormilhit iGormilhit deleted the person-detailed-view branch January 23, 2019 09:26
@iGormilhit iGormilhit mentioned this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants