Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIEWS: fix $ref relations #183

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Conversation

jma
Copy link
Contributor

@jma jma commented Jan 25, 2019

⚠️ the admin views are not yet back

  • FIX: document search view
  • FIX: document detailed view
  • FIX: patron profile view
  • FIX: item detailed view
  • BETTER: library facet are based on library pid

Signed-off-by: Johnny Mariéthoz johnny.mariethoz@rero.ch

TESTS

  • ./scripts/bootstrap
  • ./run-tests.sh
  • ./scripts/setup

@jma jma force-pushed the views-refs-refactoring branch from 8a38b38 to 6cd0428 Compare January 25, 2019 13:16
@NicolasLabat
Copy link
Contributor

Documents detailed view correctly displayed for librarians but not for patrons.
Error messages : AttributeError: type object 'Item' has no attribute 'requested_by_patron' OR AttributeError: type object 'Item' has no attribute 'loaned_to_patron'

@Garfield-fr
Copy link
Contributor

Bug on document list: The status is still not available even if the documents are available.

@Garfield-fr Garfield-fr self-requested a review January 28, 2019 06:59
@jma jma force-pushed the views-refs-refactoring branch from 6cd0428 to 61d52fb Compare January 28, 2019 09:47
- FIX: document search view
- FIX: document detailed view
- FIX: patron profile view
- FIX: item detailed view
- BETTER: library facet are based on library pid

Signed-off-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Signed-off-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma force-pushed the views-refs-refactoring branch from 61d52fb to 5aad4dc Compare January 28, 2019 09:56
@jma jma merged commit 1659f38 into rero:refs-refactoring Jan 29, 2019
@jma jma deleted the views-refs-refactoring branch January 30, 2019 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants