Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: copy manifest.json to fix tests #1927

Merged
merged 1 commit into from
May 17, 2021
Merged

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented May 17, 2021

  • Copies the manifest.json to ${INVENIO_INSTANCE_PATH}/static/dist,
    something changed in invenio-assets and this file is missing.

Co-Authored-by: Peter Weber peter.weber@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

* Copies the `manifest.json` to ${INVENIO_INSTANCE_PATH}/static/dist,
  something changed in `invenio-assets` and this file is missing.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@rerowep rerowep added the dev: tests For all types of tests: unit tests, e2e (Cypress)... label May 17, 2021
@rerowep rerowep self-assigned this May 17, 2021
@iGormilhit iGormilhit added this to the v1.3.0 milestone May 17, 2021
@rerowep rerowep merged commit e6c4312 into rero:dev May 17, 2021
@rerowep rerowep deleted the wep-fix-tests branch May 17, 2021 10:15
rerowep added a commit to rerowep/rero-ils that referenced this pull request May 18, 2021
* Removes rero#1927.
* Updates python packages.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit that referenced this pull request May 18, 2021
* Removes #1927.
* Updates python packages.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: tests For all types of tests: unit tests, e2e (Cypress)...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants