User interface: admin pages and jinja templates #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jma
force-pushed
the
layout-minor-corrections
branch
3 times, most recently
from
b3835cf to
7112984
Compare
|
On the list, the arrow on the right on the connected records is not visible. It must be put before the text on the left. |
|
I don't know if it's right to put an "add" button for a item on the list. I think it should be in the document. |
Garfield-fr
requested changes
Feb 15, 2019
| }) | ||
| export class BioInformationsPipe implements PipeTransform { | ||
|
|
||
| transform(value: any, args?: any): any { |
There was a problem hiding this comment.
args is not used in function ?
There was a problem hiding this comment.
no this has been generated by angular tools, I will remove it.
| }) | ||
| export class BirthDatePipe implements PipeTransform { | ||
|
|
||
| transform(value: any, args?: any): any { |
There was a problem hiding this comment.
args is not used in function ?
| this.recordsService | ||
| .getRecords('locations', 1, 100, `library.pid:${libraryPid}`) | ||
| .subscribe(data => { | ||
| console.log('recieved', data); |
| this.recordsService.delete('locations', pid).subscribe(locations => { | ||
| this.locations = this.locations.filter(location => location.metadata.pid !== pid); | ||
| }); | ||
| console.log(pid); |
|
In the list of libraries, the arrow is on the left when the information is closed, but on the right when it is open. |
jma
force-pushed
the
layout-minor-corrections
branch
from
7112984 to
9be0838
Compare
|
@Garfield-fr I was unable to reproduce the arrow position in the libraries view nor seen the json in the item view. |
jma
force-pushed
the
layout-minor-corrections
branch
4 times, most recently
from
7b5e2dc to
0fc0c97
Compare
Garfield-fr
requested changes
Feb 18, 2019
| }) | ||
| export class BioInformationsPipe implements PipeTransform { | ||
|
|
||
| transform(value: any, args?: any): any { |
| @@ -75,6 +80,10 @@ export class EditorComponent implements OnInit { | |||
| this.schemaForm.schema.properties.document | |||
| .properties['$ref']['default'] = urlPerfix + query.document; | |||
| } | |||
| if (this.recordType === 'locations' && query.library) { | |||
| this.redirectRecordType = 'libraries'; | |||
| this.schemaForm.schema.properties.library.properties['$ref']['default'] = 'http://ils.rero.ch/api/libraries/' + query.library; | |||
There was a problem hiding this comment.
Use ApiService ton generate the url
jma
force-pushed
the
layout-minor-corrections
branch
2 times, most recently
from
9d68bc2 to
1bd5816
Compare
Garfield-fr
approved these changes
Feb 19, 2019
jma
force-pushed
the
layout-minor-corrections
branch
from
1bd5816 to
8cb9f8e
Compare
* BETTER: lighten the front page search input button color * BETTER: resize the front page background image * BETTER: remove unused SCSS rules or replace them by a bootstrap class * BETTER: enhance the search results views * BETTER: enhance the editors views * NEW: add delete fonction in libraries and documents brief views * FIX: fix locale for schema and forms * add a rule for typscript files in the .editorconfig Signed-off-by: Igor Milhit <igor.milhit@rero.ch> Co-authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma
force-pushed
the
layout-minor-corrections
branch
from
8cb9f8e to
85ba8d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Signed-off-by: Igor Milhit igor.milhit@rero.ch
To test