circulation: fix request with different locations #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
f: circulation
jma
force-pushed
the
maj-fix-requests
branch
2 times, most recently
from
ae41fd9
to
53828f1
Compare
lauren-d
approved these changes
Aug 4, 2021
tests/api/holdings/test_patterns.py
Outdated
| @@ -147,6 +147,7 @@ def test_receive_regular_issue_api( | |||
| 'api_holding.receive_regular_issue', | |||
| url_data=dict(holding_pid=holding.pid) | |||
| ) | |||
| print(data) | |||
pronguen
approved these changes
Aug 5, 2021
BadrAly
approved these changes
Aug 5, 2021
* Checks the owning location `allow_request` property to decide if an item can be requested. * Closes rero#2234. * Logs an error and do a db rollback for holding views. * Fixes tests that failed every two monthes. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks the owning location
allow_requestproperty to decide if an item can be requested.Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Code review check list