Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

local fields: improve validation #2268

Merged
merged 1 commit into from
Aug 4, 2021
Merged

local fields: improve validation #2268

merged 1 commit into from
Aug 4, 2021

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Aug 3, 2021 •
edited
Loading

The validation of the local field forbids to have 2 records
on the same document for the same organization.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
Co-Authored-by: Johnny Mariéthoz johnny.mariethoz@rero.ch

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

How to test?

  • Check if possible to duplicate record local fields
  • Check Display

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@Garfield-fr Garfield-fr self-assigned this Aug 3, 2021
@Garfield-fr Garfield-fr added this to the v1.5.0 milestone Aug 3, 2021
@Garfield-fr Garfield-fr added the enhancement Improvement of an existing feature label Aug 3, 2021
@Garfield-fr Garfield-fr marked this pull request as draft August 3, 2021 12:00
@Garfield-fr Garfield-fr marked this pull request as ready for review August 3, 2021 12:21
@Garfield-fr Garfield-fr force-pushed the zub-local-fields branch 3 times, most recently from 2ff8f5e to 904c7f3 Compare August 3, 2021 12:39
jma
jma approved these changes Aug 4, 2021
View reviewed changes
rero_ils/modules/local_fields/api.py Outdated Show resolved Hide resolved
tests/api/local_fields/test_local_fields_rest.py Outdated Show resolved Hide resolved
@Garfield-fr @jma
local fields: improve validation
42284d0 
The validation of the local field forbids to have 2 records
on the same document for the same organization.

* Closes rero#2257

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
@Garfield-fr Garfield-fr merged commit 2cca223 into rero:dev Aug 4, 2021
@Garfield-fr Garfield-fr deleted the zub-local-fields branch August 4, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@BadrAly BadrAly BadrAly approved these changes

@benerken benerken benerken approved these changes

@jma jma jma approved these changes

Assignees

@Garfield-fr Garfield-fr

Labels
enhancement Improvement of an existing feature
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

Some added local fields not displayed in the professional interface
5 participants
@Garfield-fr @jma @benerken @BadrAly @lauren-d