document: fix size of the thumbnail on mobile detail view #2958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
force-pushed
the
zub-thumbnail
branch
from
f57636d to
be4c261
Compare
rerowep
approved these changes
Jun 14, 2022
PascalRepond
approved these changes
Jun 14, 2022
zannkukai
reviewed
Jun 16, 2022
There was a problem hiding this comment.
You create 2 rules for same selector.
at L22, you create a general rules, applying in all cases.
at L35, you create a rule, only applying if media is "medium or smaller". This rule seems not useless (all the figure#thumbnail .thumb block into @media) because already define as general rule.
* Closes rero#2733. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr
force-pushed
the
zub-thumbnail
branch
from
be4c261 to
9437a60
Compare
zannkukai
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch