Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

views: disabling edit/delete buttons for items of other organisation #306

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented May 17, 2019

  • NEW Fixes issue when edit/delete buttons are displayed for users of other organisations.

Signed-off-by: Aly Badr aly.badr@rero.ch

  • Display a document having items from two organisations (possibly http://localhost:5000/documents/299)
  • The edit/delete buttons are only displayed for items of your organisation

@BadrAly BadrAly changed the title views: Disabling edit/delete buttons for items of other organisation views: disabling edit/delete buttons for items of other organisation May 17, 2019
@BadrAly BadrAly requested review from jma, rerowep, iGormilhit and reropag May 17, 2019 12:29
Copy link
Contributor

@reropag reropag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works well.

@jma
Copy link
Contributor

jma commented May 20, 2019

Please add tests.

@BadrAly BadrAly force-pushed the baa-#867-disable-edit-delete-for-other-orgs branch 6 times, most recently from 7a30a90 to ee45173 Compare May 20, 2019 14:39
@jma jma force-pushed the US737-two-organisations branch from 846de2d to 4ce2905 Compare May 20, 2019 14:45
@BadrAly BadrAly force-pushed the baa-#867-disable-edit-delete-for-other-orgs branch 2 times, most recently from b398b40 to 47c4b85 Compare May 20, 2019 14:49
@BadrAly BadrAly closed this May 20, 2019
@BadrAly BadrAly force-pushed the baa-#867-disable-edit-delete-for-other-orgs branch from 919b827 to 4ce2905 Compare May 20, 2019 14:57
@BadrAly BadrAly reopened this May 20, 2019
@BadrAly BadrAly force-pushed the baa-#867-disable-edit-delete-for-other-orgs branch from 214f667 to f658bc7 Compare May 20, 2019 15:06
* NEW Fixes issue when edit/delete buttons are displayed for users of other organisations.

Signed-off-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly force-pushed the baa-#867-disable-edit-delete-for-other-orgs branch from f658bc7 to 25cbaf5 Compare May 20, 2019 15:17
@jma jma merged commit 796f7e4 into rero:US737-two-organisations May 20, 2019
@BadrAly BadrAly deleted the baa-#867-disable-edit-delete-for-other-orgs branch May 28, 2019 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants