Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexing: update mef persons mapping #333

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Jun 7, 2019

  • Adds analyzer on biographical_information, preferred_name_for_person,
    authorized_access_point_representing_a_person and variant_name_for_person fields.

How to test:

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

@jma
Copy link
Contributor

jma commented Jun 11, 2019

it would be great to have in the detailed message commit an explanation of what is a "global char_group tokenizer" or better the name and the description of the new analyzer.

@@ -420,7 +420,7 @@
"address": "Centre culturel",
"code": "APROZ",
"email": "reroilstest+aproz@gmail.com",
"name": "Bibliothèque d'Aproz",
"name": "Biblioth\u00e8que d'Aproz",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both (é and \u00e8)should be supported

jma and others added 2 commits June 11, 2019 16:29
Improves users for tests: each user has only one role, patron, librarian
or system librarian. New users has been created to be close to a real
system.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Co-Authored-by: Aly Badr <aly.badr@rero.ch>
* Adds analyzer on name and description fields.
* Adds es config on test to support templates.
* Fixes type on description field.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr force-pushed the zub-#876-mef-person-mapping branch from 9107505 to 0dc33ee Compare June 11, 2019 14:38
* Adds analyzer on biographical_information, preferred_name_for_person,
  authorized_access_point_representing_a_person and variant_name_for_person fields.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr force-pushed the zub-#876-mef-person-mapping branch from 0dc33ee to 0510a4c Compare June 11, 2019 14:47
@Garfield-fr Garfield-fr merged commit 3a71711 into rero:US671-Search_and_Ranking Jun 11, 2019
@Garfield-fr Garfield-fr deleted the zub-#876-mef-person-mapping branch June 11, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants