Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications: create periodic task to create and send notifications #343

Merged
merged 1 commit into from
Jun 17, 2019

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Jun 14, 2019

  • Adds celery task cronned every morning at 4h00 to create and send overdue and due_soon notifications.

Signed-off-by: Aly Badr aly.badr@rero.ch

@BadrAly BadrAly requested review from jma, reropag, iGormilhit and Garfield-fr and removed request for jma and reropag June 14, 2019 13:36
@BadrAly BadrAly force-pushed the baa-#903-notifications-task branch from 68ff344 to 6f18476 Compare June 14, 2019 14:00
@BadrAly BadrAly force-pushed the baa-#903-notifications-task branch 2 times, most recently from da965b6 to 0b1ea30 Compare June 17, 2019 08:44
@jma
Copy link
Contributor

jma commented Jun 17, 2019

please add an end point for each item in the message commit: there are supposed to be sentences.

rero_ils/modules/notifications/tasks.py Outdated Show resolved Hide resolved
rero_ils/modules/notifications/tasks.py Outdated Show resolved Hide resolved
tests/api/test_tasks.py Show resolved Hide resolved
* Adds celery task cronned every morning at 4h00 to create and send overdue and due_soon notifications.

Signed-off-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly force-pushed the baa-#903-notifications-task branch from 0b1ea30 to 98f89e9 Compare June 17, 2019 11:10
@BadrAly BadrAly requested a review from jma June 17, 2019 12:10
@BadrAly BadrAly merged commit cb50f96 into rero:US341 Jun 17, 2019
@BadrAly BadrAly deleted the baa-#903-notifications-task branch July 1, 2019 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants