Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document: advanced search config and endpoint #3496

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Oct 24, 2023

  • Adds configuration for enabled/disabled advanced search.
  • Adds a new field in the document schema to group
    call number for holdings and items.
  • Adds a new endpoint for advanced search config.

⚠️ update ES mapping and reindex ES documents

@Garfield-fr Garfield-fr self-assigned this Oct 24, 2023
@github-actions github-actions bot added f: search f: user management f: data migration Data migration from a legacy system or a previous version labels Oct 24, 2023
rero_ils/modules/documents/api_views.py Outdated Show resolved Hide resolved
rero_ils/modules/documents/api_views.py Outdated Show resolved Hide resolved
@Garfield-fr Garfield-fr force-pushed the zub-document-advanced-search branch 4 times, most recently from 1947830 to 6fe0152 Compare October 26, 2023 05:53
@Garfield-fr Garfield-fr changed the title config: add document advanced seach flag @Garfield-fr document: advanced search config and endpoint Oct 26, 2023
@Garfield-fr Garfield-fr changed the title @Garfield-fr document: advanced search config and endpoint document: advanced search config and endpoint Oct 26, 2023
@Garfield-fr Garfield-fr force-pushed the zub-document-advanced-search branch 2 times, most recently from 5916009 to 0d8724e Compare October 26, 2023 05:55
@Garfield-fr Garfield-fr marked this pull request as ready for review October 26, 2023 07:57
@PascalRepond
Copy link
Contributor

Could you add migration instructions? Update mappings, reindex documents?

@PascalRepond
Copy link
Contributor

PascalRepond commented Oct 31, 2023

Tests

  • REP: The new search bar position is weird. Is it possible to move it above the results number and filter buttons:
    image
  • REP: Field selector dropdown values should be fixed ordered (order in the US)
  • MD: the expert search toggle is removed when reloading the page or the search.
  • REP [not completely related]: If I click "extend to all organisations" after an expert search, it goes back to "simple=1".
  • REP: It would be nicer if the expert search toggle and advanced builder button were closer to the search field
    ZUB: It's not easy to implement this display, as the expert search is part of the filters.
    Capture d'écran 2023-10-31 141631
  • REP: problems in the targeted fields (specs were incorrect), see detailed comments in code

rero_ils/config.py Outdated Show resolved Hide resolved
rero_ils/config.py Outdated Show resolved Hide resolved
rero_ils/config.py Outdated Show resolved Hide resolved
rero_ils/config.py Outdated Show resolved Hide resolved
rero_ils/config.py Outdated Show resolved Hide resolved
rero_ils/config.py Outdated Show resolved Hide resolved
rero_ils/config.py Outdated Show resolved Hide resolved
rero_ils/config.py Outdated Show resolved Hide resolved
rero_ils/config.py Outdated Show resolved Hide resolved
rero_ils/config.py Outdated Show resolved Hide resolved
@Garfield-fr Garfield-fr force-pushed the zub-document-advanced-search branch 2 times, most recently from 4b2752c to a9e64e0 Compare November 13, 2023 07:12
@PascalRepond
Copy link
Contributor

PascalRepond commented Nov 14, 2023

Tests (round 2)

  • MD: 500 error if I use double quotes without deselecting the option 'phrase'. Once I get the error I cannot use the advanced search during 5min (local storage). The page is blocked even after a refresh.
  • REP: "build advanced query button" should be always visible even if the expert toggle is disabled (cf. acceptance criteria)
  • REP: When I reload the page after an adavanced search and re-open the advanced query builder, I get an error "ERROR TypeError: this.fieldMappingMap is undefined"
  • REP: Order and name of the dropdowns should be: Local fields (document) -> Local fields (holdings) -> Local fields (items)

@Garfield-fr Garfield-fr force-pushed the zub-document-advanced-search branch 6 times, most recently from 3c64189 to f8bc474 Compare November 14, 2023 13:34
rero_ils/config.py Outdated Show resolved Hide resolved
* Adds configuration for enabled/disabled advanced search.
* Adds a new field in the document schema to group
  call number for holdings and items.
* Adds a new endpoint for advanced search config.

⚠️  update ES mapping and reindex ES documents

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr merged commit 4f2374b into rero:staging Dec 7, 2023
4 checks passed
@Garfield-fr Garfield-fr deleted the zub-document-advanced-search branch December 11, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: data migration Data migration from a legacy system or a previous version f: search f: user management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants