Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues: fix issue when wrong patron displayed after a checkin #370

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Jul 2, 2019

@BadrAly BadrAly requested a review from iGormilhit July 2, 2019 06:32
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is fine. Could you improve the commit message?

circulation: display the patron returning the item

- FIX Does not display the patron that requested the check-in item in the context of a shortcut.
- FIX Fixes #357.

Thanks.

* FIX Does not display the patron that requested the check-in item in the context of a shortcut.
* Fix Fixes rero#357

Signed-off-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly force-pushed the baa-fix-issue-357 branch from 52faf7f to e384547 Compare July 2, 2019 13:13
@BadrAly
Copy link
Author

BadrAly commented Jul 2, 2019

The code is fine. Could you improve the commit message?

circulation: display the patron returning the item

- FIX Does not display the patron that requested the check-in item in the context of a shortcut.
- FIX Fixes #357.

Thanks.

Done

@BadrAly BadrAly requested a review from iGormilhit July 2, 2019 13:49
@BadrAly BadrAly merged commit f5202dd into rero:dev Jul 2, 2019
@BadrAly BadrAly deleted the baa-fix-issue-357 branch July 3, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants