fix(documents): delete orphan harvested documents #3777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PascalRepond
commented
Nov 12, 2024
PascalRepond
commented
- Closes Periodically delete orphan harvested documents #3776.
PascalRepond
force-pushed
the
rep-harvest
branch
2 times, most recently
from
5e30c19
to
03927a1
Compare
rerowep
requested changes
Nov 12, 2024
rero_ils/modules/documents/tasks.py
Outdated
| if delete: | ||
| try: | ||
| if doc.reasons_not_to_delete() == {"others": {"harvested": True}}: | ||
| doc.delete(dbcommit=True, delindex=True, force=True) |
There was a problem hiding this comment.
Not sure force=True will do the trick. Force will delete the persistent identifier in DB. I think yo have to set harvested to False before deleting.
PascalRepond
force-pushed
the
rep-harvest
branch
2 times, most recently
from
30f3035
to
dab526b
Compare
PascalRepond
force-pushed
the
rep-harvest
branch
from
dab526b
to
6532ff5
Compare
* Closes rero#3776. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond
force-pushed
the
rep-harvest
branch
from
6532ff5
to
86b09b1
Compare
rerowep
approved these changes
Nov 12, 2024
jma
approved these changes
Nov 18, 2024
| for pid in pids: | ||
| if doc := Document.get_record_by_pid(pid): | ||
| if verbose: | ||
| click.secho(f"Deleting orphan harvested: {pid}", fg="yellow") |
There was a problem hiding this comment.
This is available only using python click.
| except Exception: | ||
| msg = f"COULD NOT DELETE ORPHAN HARVESTED: {pid} {doc.reasons_not_to_delete()}" | ||
| if verbose: | ||
| click.secho(f"ERROR: {msg}", fg="red") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.